The SIO2 project
  1. The SIO2 project
  2. SIO-2049

Differentiate colours between "OK" and "Partially OK"

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: None
    • Component/s: OIOIOI
    • Labels:

      Description

      When the problem grader assigns only a fraction of points for a test, it is still displayed as "OK" with green background, which could be misleading. It would be better to write "Partially OK" or just "OK" with a different bg colour (say, yellow).

      I mean, when the grader outputs:
      "OK
      some message
      50"
      then the program is assigned 50% of the points. It is a different situation from the one when it gets 100% of the points but still the only difference in the display is in the footnote to the test case. Some of the contestants find this situation confusing.

        Issue Links

          Activity

          Hide
          Michał Sidor added a comment -
          To ja może rozjaśnię, o co chodzi Jakubowi:

          Wynik całego submita jest już rozróżnialny, natomiast jurorom zależy też na wynikach poszczególnych testów, żeby wynik testu na 20% punktów (takie zadania się pojawiają ostatnio, że 20% punktów jest za podanie częściowego poprawnego wyniku) lub taki gdzie nastąpił liniowy spadek punktów od czasu, żeby taki test nie był tak samo zielony jak test na którym submit dostał bezdyskusyjne 100%.

          Ja widzę potrzebę modyfikacji oioioi/programs/models.py:TestReport i template'a z tejże paczki który te TestReporty renderuje. Można się zainspirować pracą Piotra, która jest na masterze w commicie f8e389259eddd0e41f14f6c1a1b131a4d6e9b859. Wydaje mi się, że największą trudnością tutaj jest to, że TestReport ma integerowy test_max_score ale Score'owy score i nie wiem jak to się zachowa dla Potyczek, gdzie score dla testu jest None – to wymaga zastanowienia i dobrego rozegrania.
          Show
          Michał Sidor added a comment - To ja może rozjaśnię, o co chodzi Jakubowi: Wynik całego submita jest już rozróżnialny, natomiast jurorom zależy też na wynikach poszczególnych testów, żeby wynik testu na 20% punktów (takie zadania się pojawiają ostatnio, że 20% punktów jest za podanie częściowego poprawnego wyniku) lub taki gdzie nastąpił liniowy spadek punktów od czasu, żeby taki test nie był tak samo zielony jak test na którym submit dostał bezdyskusyjne 100%. Ja widzę potrzebę modyfikacji oioioi/programs/models.py:TestReport i template'a z tejże paczki który te TestReporty renderuje. Można się zainspirować pracą Piotra, która jest na masterze w commicie f8e389259eddd0e41f14f6c1a1b131a4d6e9b859. Wydaje mi się, że największą trudnością tutaj jest to, że TestReport ma integerowy test_max_score ale Score'owy score i nie wiem jak to się zachowa dla Potyczek, gdzie score dla testu jest None – to wymaga zastanowienia i dobrego rozegrania.
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 1
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 2
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 3
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 4
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b

            People

            • Assignee:
              Szymon Acedański
              Reporter:
              Jakub Radoszewski
              TAG Developer:
              Przemysław Podleśny
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: