The SIO2 project
  1. The SIO2 project
  2. SIO-2049

Differentiate colours between "OK" and "Partially OK"

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: None
    • Component/s: OIOIOI
    • Labels:

      Description

      When the problem grader assigns only a fraction of points for a test, it is still displayed as "OK" with green background, which could be misleading. It would be better to write "Partially OK" or just "OK" with a different bg colour (say, yellow).

      I mean, when the grader outputs:
      "OK
      some message
      50"
      then the program is assigned 50% of the points. It is a different situation from the one when it gets 100% of the points but still the only difference in the display is in the footnote to the test case. Some of the contestants find this situation confusing.

        Issue Links

          Activity

          Piotr Wojtczak made changes -
          Field Original Value New Value
          Assignee Piotr Wojtczak [ starosta ]
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I0e3d821621277702dabadcca9a75f6fe66355f55, patchset 1
          https://gerrit.sio2project.mimuw.edu.pl/3105

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I0e3d821621277702dabadcca9a75f6fe66355f55
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I0e3d821621277702dabadcca9a75f6fe66355f55, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3105 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I0e3d821621277702dabadcca9a75f6fe66355f55
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 1
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 2
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 3
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 4
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 5
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 5 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 6
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 6 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 7
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 7 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 8
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 8 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 9
          https://gerrit.sio2project.mimuw.edu.pl/3107

          SIO-2049 Differentiate colours between "OK" and "Partially OK"

          Changed the colors and messages of a submission based on the score. Scores less than maximum no longer
          look the same as the max ones.

          Also introduced some cosmetic changes to color pallete and gradients.

          Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45, patchset 9 https://gerrit.sio2project.mimuw.edu.pl/3107 SIO-2049 Differentiate colours between "OK" and "Partially OK" Changed the colors and messages of a submission based on the score. Scores less than maximum no longer look the same as the max ones. Also introduced some cosmetic changes to color pallete and gradients. Change-Id: I810e8be3a8ad8b7e3b8475caa1cc8282f7c66c45
          Hide
          Piotr Wojtczak added a comment -
          Scores are now distinguishable by color.
          Show
          Piotr Wojtczak added a comment - Scores are now distinguishable by color.
          Piotr Wojtczak made changes -
          Status New [ 10000 ] Resolved [ 5 ]
          Assignee Piotr Wojtczak [ starosta ] Szymon Acedański [ accek ]
          Resolution Fixed [ 1 ]
          Piotr Wojtczak made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Szymon Acedański [ accek ] Piotr Wojtczak [ starosta ]
          Hide
          Jakub Radoszewski added a comment -
          Poprawka nie weszła do SIO2. Podczas II etapu XXVI OI znów mieliśmy ten problem:
          https://sio2.mimuw.edu.pl/c/oi26-2/s/312295/
          Show
          Jakub Radoszewski added a comment - Poprawka nie weszła do SIO2. Podczas II etapu XXVI OI znów mieliśmy ten problem: https://sio2.mimuw.edu.pl/c/oi26-2/s/312295/
          Hide
          Jakub Radoszewski added a comment -
          Halo, halo, dalej tego nie ma w SIO... Teraz już XXVII OI:
          https://sio2.mimuw.edu.pl/c/oi27-1/s/344306/
          Show
          Jakub Radoszewski added a comment - Halo, halo, dalej tego nie ma w SIO... Teraz już XXVII OI: https://sio2.mimuw.edu.pl/c/oi27-1/s/344306/
          Hide
          Michał Sidor added a comment -
          To ja może rozjaśnię, o co chodzi Jakubowi:

          Wynik całego submita jest już rozróżnialny, natomiast jurorom zależy też na wynikach poszczególnych testów, żeby wynik testu na 20% punktów (takie zadania się pojawiają ostatnio, że 20% punktów jest za podanie częściowego poprawnego wyniku) lub taki gdzie nastąpił liniowy spadek punktów od czasu, żeby taki test nie był tak samo zielony jak test na którym submit dostał bezdyskusyjne 100%.

          Ja widzę potrzebę modyfikacji oioioi/programs/models.py:TestReport i template'a z tejże paczki który te TestReporty renderuje. Można się zainspirować pracą Piotra, która jest na masterze w commicie f8e389259eddd0e41f14f6c1a1b131a4d6e9b859. Wydaje mi się, że największą trudnością tutaj jest to, że TestReport ma integerowy test_max_score ale Score'owy score i nie wiem jak to się zachowa dla Potyczek, gdzie score dla testu jest None – to wymaga zastanowienia i dobrego rozegrania.
          Show
          Michał Sidor added a comment - To ja może rozjaśnię, o co chodzi Jakubowi: Wynik całego submita jest już rozróżnialny, natomiast jurorom zależy też na wynikach poszczególnych testów, żeby wynik testu na 20% punktów (takie zadania się pojawiają ostatnio, że 20% punktów jest za podanie częściowego poprawnego wyniku) lub taki gdzie nastąpił liniowy spadek punktów od czasu, żeby taki test nie był tak samo zielony jak test na którym submit dostał bezdyskusyjne 100%. Ja widzę potrzebę modyfikacji oioioi/programs/models.py:TestReport i template'a z tejże paczki który te TestReporty renderuje. Można się zainspirować pracą Piotra, która jest na masterze w commicie f8e389259eddd0e41f14f6c1a1b131a4d6e9b859. Wydaje mi się, że największą trudnością tutaj jest to, że TestReport ma integerowy test_max_score ale Score'owy score i nie wiem jak to się zachowa dla Potyczek, gdzie score dla testu jest None – to wymaga zastanowienia i dobrego rozegrania.
          Michał Sidor made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Assignee Piotr Wojtczak [ starosta ]
          Michał Sidor made changes -
          Labels tag1
          Szymon Acedański made changes -
          Link This issue relates to SIO-2291 [ SIO-2291 ]
          Przemysław Podleśny made changes -
          Assignee Przemysław Podleśny [ hayven ]
          Przemysław Podleśny made changes -
          TAG Developer Przemysław Podleśny [ hayven ]
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 1
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 2
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 3
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 4
          https://gerrit.sio2project.mimuw.edu.pl/3390

          (SIO-2049) Test report color differentiation between "OK" and "Partially OK"

          Just like with the submission color, the test reports marked as "OK"
          will now be highlighted with different shades of green, depending on
          the fraction of the maximum score available for the test obtained
          by the submission.

          Test reports without defined maximum scores will always be highlighted
          according only to their status, i.e. those of them that are marked
          as "OK" will always receive the default, full shade of green.

          Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I195ae2a7940083b53a6d77999b03ba051436703b, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/3390 ( SIO-2049 ) Test report color differentiation between "OK" and "Partially OK" Just like with the submission color, the test reports marked as "OK" will now be highlighted with different shades of green, depending on the fraction of the maximum score available for the test obtained by the submission. Test reports without defined maximum scores will always be highlighted according only to their status, i.e. those of them that are marked as "OK" will always receive the default, full shade of green. Change-Id: I195ae2a7940083b53a6d77999b03ba051436703b
          Przemysław Podleśny made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Przemysław Podleśny [ hayven ] Szymon Acedański [ accek ]
          Resolution Fixed [ 1 ]
          Szymon Acedański made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          New New Resolved Resolved
          379d 3h 50m 1 Piotr Wojtczak 2018-12-12 16:25
          Closed Closed Reopened Reopened
          358d 6h 14m 1 Michał Sidor 2019-12-5 22:40
          Reopened Reopened Resolved Resolved
          88d 16h 56m 1 Przemysław Podleśny 2020-03-3 15:36
          Resolved Resolved Closed Closed
          31m 55s 2 Szymon Acedański 2020-03-3 16:08

            People

            • Assignee:
              Szymon Acedański
              Reporter:
              Jakub Radoszewski
              TAG Developer:
              Przemysław Podleśny
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: