[SIO-2233] Adapt old-style settings.MIDDLEWARE_CLASSES to the new version - SIO2

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: TAG 2018/19 Sprint 2
Fix Version/s: None
Component/s: OIOIOI
Labels:
- migration

Description

In Django 1.10 "old-style" middleware that uses settings.MIDDLEWARE_CLASSES is deprecated. We must adapt it to the new style or use new MIDDLEWARE setting.

Docs: https://docs.djangoproject.com/en/2.1/releases/1.10/#id3 (12th dot)

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Gerrit Gerrit added a comment - 2019-05-1 18:17

Change oioioi~master~I5811b92c9294f2d87d61bc70d672dcaf4e5dacef, patchset 1
https://gerrit.sio2project.mimuw.edu.pl/3211

(no-ticket) Fix pytest.ini so that it treats all deprecation warnings as errors

In the earlier similar commit class PendingDeprecationWarning was
not added to the list warning --> error (did not generated an error),
but it is now.
Additionally, new exceptions were added and appropriate
Jira issues were created:

~~SIO-2155~~ Set the app_name attribute in urls modules strikes back
~~SIO-2233~~ Adapt old-style settings.MIDDLEWARE_CLASSES to the new version
~~SIO-2234~~ Change use of User.is_authenticated() and User.is_anonymous() methods
~~SIO-2235~~ Fix test_portals.json fixture

Change-Id: I5811b92c9294f2d87d61bc70d672dcaf4e5dacef

Show

Gerrit Gerrit added a comment - 2019-05-1 18:17 Change oioioi~master~I5811b92c9294f2d87d61bc70d672dcaf4e5dacef, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3211 (no-ticket) Fix pytest.ini so that it treats all deprecation warnings as errors In the earlier similar commit class PendingDeprecationWarning was not added to the list warning --> error (did not generated an error), but it is now. Additionally, new exceptions were added and appropriate Jira issues were created: SIO-2155 Set the app_name attribute in urls modules strikes back SIO-2233 Adapt old-style settings.MIDDLEWARE_CLASSES to the new version SIO-2234 Change use of User.is_authenticated() and User.is_anonymous() methods SIO-2235 Fix test_portals.json fixture Change-Id: I5811b92c9294f2d87d61bc70d672dcaf4e5dacef

15 older comments

Hide

Permalink

Gerrit Gerrit added a comment - 2019-05-13 15:40

Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/3214

(~~SIO-2233~~) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version

Slighty new semantic of MIDDLEWARE changed behaviour of
SuFirstTimeRedirectionMiddleware, but it seems to
work in an acceptable way.

Fixed one test in oioioi/base.

Added minimal version requirements for dj-pagination,
django-otp and django-debug-toolbar.

Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Show

Gerrit Gerrit added a comment - 2019-05-13 15:40 Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 7 https://gerrit.sio2project.mimuw.edu.pl/3214 ( SIO-2233 ) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version Slighty new semantic of MIDDLEWARE changed behaviour of SuFirstTimeRedirectionMiddleware, but it seems to work in an acceptable way. Fixed one test in oioioi/base. Added minimal version requirements for dj-pagination, django-otp and django-debug-toolbar. Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Hide

Permalink

Gerrit Gerrit added a comment - 2019-05-13 18:29

Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 8
https://gerrit.sio2project.mimuw.edu.pl/3214

(~~SIO-2233~~) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version

Slighty new semantic of MIDDLEWARE changed behaviour of
SuFirstTimeRedirectionMiddleware, but it seems to
work in an acceptable way.

Fixed one test in oioioi/base.

Added minimal version requirements for dj-pagination,
django-otp and django-debug-toolbar.

Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Show

Gerrit Gerrit added a comment - 2019-05-13 18:29 Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 8 https://gerrit.sio2project.mimuw.edu.pl/3214 ( SIO-2233 ) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version Slighty new semantic of MIDDLEWARE changed behaviour of SuFirstTimeRedirectionMiddleware, but it seems to work in an acceptable way. Fixed one test in oioioi/base. Added minimal version requirements for dj-pagination, django-otp and django-debug-toolbar. Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Hide

Permalink

Gerrit Gerrit added a comment - 2019-05-14 11:06

Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 9
https://gerrit.sio2project.mimuw.edu.pl/3214

(~~SIO-2233~~) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version

Slighty new semantic of MIDDLEWARE changed behaviour of
SuFirstTimeRedirectionMiddleware, but it seems to
work in an acceptable way.

Fixed one test in oioioi/base.

Added minimal version requirements for dj-pagination,
django-otp and django-debug-toolbar.

Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Show

Gerrit Gerrit added a comment - 2019-05-14 11:06 Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 9 https://gerrit.sio2project.mimuw.edu.pl/3214 ( SIO-2233 ) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version Slighty new semantic of MIDDLEWARE changed behaviour of SuFirstTimeRedirectionMiddleware, but it seems to work in an acceptable way. Fixed one test in oioioi/base. Added minimal version requirements for dj-pagination, django-otp and django-debug-toolbar. Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Hide

Permalink

Gerrit Gerrit added a comment - 2019-05-17 9:28

Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 10
https://gerrit.sio2project.mimuw.edu.pl/3214

(~~SIO-2233~~) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version

Slighty new semantic of MIDDLEWARE changed behaviour of
SuFirstTimeRedirectionMiddleware, but it seems to
work in an acceptable way.

Fixed one test in oioioi/base.

Added minimal version requirements for dj-pagination,
django-otp and django-debug-toolbar.

Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Show

Gerrit Gerrit added a comment - 2019-05-17 9:28 Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 10 https://gerrit.sio2project.mimuw.edu.pl/3214 ( SIO-2233 ) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version Slighty new semantic of MIDDLEWARE changed behaviour of SuFirstTimeRedirectionMiddleware, but it seems to work in an acceptable way. Fixed one test in oioioi/base. Added minimal version requirements for dj-pagination, django-otp and django-debug-toolbar. Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Hide

Permalink

Gerrit Gerrit added a comment - 2019-05-20 18:23

Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 11
https://gerrit.sio2project.mimuw.edu.pl/3214

(~~SIO-2233~~) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version

Slighty new semantic of MIDDLEWARE changed behaviour of
SuFirstTimeRedirectionMiddleware, but it seems to
work in an acceptable way.

Fixed one test in oioioi/base.

Added minimal version requirements for dj-pagination,
django-otp and django-debug-toolbar.

Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

Show

Gerrit Gerrit added a comment - 2019-05-20 18:23 Change oioioi~master~I4a66cb476e533bc76662d79c7beba6915b128b4f, patchset 11 https://gerrit.sio2project.mimuw.edu.pl/3214 ( SIO-2233 ) Adapt old-style settings.MIDDLEWARE_CLASSES to the new version Slighty new semantic of MIDDLEWARE changed behaviour of SuFirstTimeRedirectionMiddleware, but it seems to work in an acceptable way. Fixed one test in oioioi/base. Added minimal version requirements for dj-pagination, django-otp and django-debug-toolbar. Change-Id: I4a66cb476e533bc76662d79c7beba6915b128b4f

People

Assignee:

Szymon Acedański

Reporter:

Marek Żochowski

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

2019-05-1 17:56

Updated:

2020-03-3 16:08

Resolved:

2019-05-21 10:14

Agile

View on Board