The SIO2 project
  1. The SIO2 project
  2. SIO-2027

Remove leftover grappelli CSS classes

        Details

        • Type: Bug Bug
        • Status: Closed Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: OIOIOI
        • Labels:

          Description

          There are some leftover `grp-*` CSS classes from Grappelli (which we stopped using when we moved to Django 1.9), mostly in `oioioi/programs/templates/programs/admin/tests_inline.html` but also in some other files.

          Some things that are usually done with special HTML tags (eg. tables) were done with divs with special `grp-*` class, which doesn't work anymore, since Grappelli is no longer present. Other parts of styling may also be broken.

          I guess it'll be necessary to find out what each of those classes did, and how to replace it with something that works with bootstrap.

            Issue Links

            relates to

            Bug - A problem which impairs or prevents the functions of the product. SIO-2036 Table for editing tests renders improperly

            • Trivial - Cosmetic problem like misspelt words or misaligned text.
            • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

              Activity

              Ascending order - Click to sort in descending order
              Wojciech Dubiel made changes -
              Field Original Value New Value
              Rank Ranked higher
              Szymon Acedański made changes -
              Labels easy
              Filip Mikina made changes -
              Assignee Filip Mikina [ fiffeek ]
              Jakub Bartmiński made changes -
              Link This issue relates to SIO-2036 [ SIO-2036 ]
              Jakub Bartmiński made changes -
              Assignee Filip Mikina [ fiffeek ] Jakub Bartmiński [ xvyx ]
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 1
              https://gerrit.sio2project.mimuw.edu.pl/3099

              [SIO-2027] Remove grappelli leftovers

              Replaced leftover grappelli classes with bootstrap in the two templates
              that were still using them, and simplified the tests_inline template.
              Also removed two leftover grappelli files, since nothing should be using
              them anymore.

              Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3
              Show
              Gerrit Gerrit added a comment - Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3099 [ SIO-2027 ] Remove grappelli leftovers Replaced leftover grappelli classes with bootstrap in the two templates that were still using them, and simplified the tests_inline template. Also removed two leftover grappelli files, since nothing should be using them anymore. Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 2
              https://gerrit.sio2project.mimuw.edu.pl/3099

              (SIO-2027) Remove grappelli leftovers

              Replaced leftover grappelli classes with bootstrap in the two templates
              that were still using them, and simplified the tests_inline template.
              Also removed two leftover grappelli files, since nothing should be using
              them anymore, and removed a reference to grappelli from another file.

              Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3
              Show
              Gerrit Gerrit added a comment - Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3099 ( SIO-2027 ) Remove grappelli leftovers Replaced leftover grappelli classes with bootstrap in the two templates that were still using them, and simplified the tests_inline template. Also removed two leftover grappelli files, since nothing should be using them anymore, and removed a reference to grappelli from another file. Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3
              Gerrit Gerrit made changes -
              Status New [ 10000 ] Resolved [ 5 ]
              Assignee Jakub Bartmiński [ xvyx ] Szymon Acedański [ accek ]
              Resolution Fixed [ 1 ]
              Szymon Acedański made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Transition Time In Source Status Execution Times Last Executer Last Execution Date
              New New Resolved Resolved
              		412d 15h 43m 1 Gerrit Gerrit 2018-11-28 13:32
              Resolved Resolved Closed Closed
              		118d 3h 6m 1 Szymon Acedański 2019-03-26 16:39

                People

                • Assignee:
                  Szymon Acedański
                  Reporter:
                  Wojciech Dubiel
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: