Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: None
    • Component/s: OIOIOI
    • Labels:

      Description

      There are some leftover `grp-*` CSS classes from Grappelli (which we stopped using when we moved to Django 1.9), mostly in `oioioi/programs/templates/programs/admin/tests_inline.html` but also in some other files.

      Some things that are usually done with special HTML tags (eg. tables) were done with divs with special `grp-*` class, which doesn't work anymore, since Grappelli is no longer present. Other parts of styling may also be broken.

      I guess it'll be necessary to find out what each of those classes did, and how to replace it with something that works with bootstrap.

        Issue Links

          Activity

          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 1
          https://gerrit.sio2project.mimuw.edu.pl/3099

          [SIO-2027] Remove grappelli leftovers

          Replaced leftover grappelli classes with bootstrap in the two templates
          that were still using them, and simplified the tests_inline template.
          Also removed two leftover grappelli files, since nothing should be using
          them anymore.

          Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3099 [ SIO-2027 ] Remove grappelli leftovers Replaced leftover grappelli classes with bootstrap in the two templates that were still using them, and simplified the tests_inline template. Also removed two leftover grappelli files, since nothing should be using them anymore. Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3
          Hide
          Gerrit Gerrit added a comment -
          Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 2
          https://gerrit.sio2project.mimuw.edu.pl/3099

          (SIO-2027) Remove grappelli leftovers

          Replaced leftover grappelli classes with bootstrap in the two templates
          that were still using them, and simplified the tests_inline template.
          Also removed two leftover grappelli files, since nothing should be using
          them anymore, and removed a reference to grappelli from another file.

          Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3
          Show
          Gerrit Gerrit added a comment - Change oioioi~master~I21647976cc073dd621fefceacd4ff364b3f0eac3, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3099 ( SIO-2027 ) Remove grappelli leftovers Replaced leftover grappelli classes with bootstrap in the two templates that were still using them, and simplified the tests_inline template. Also removed two leftover grappelli files, since nothing should be using them anymore, and removed a reference to grappelli from another file. Change-Id: I21647976cc073dd621fefceacd4ff364b3f0eac3

            People

            • Assignee:
              Szymon AcedaƄski
              Reporter:
              Wojciech Dubiel
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: