Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: Current Version
-
Fix Version/s: None
-
Component/s: OIOIOI
-
Labels:None
Issue Links
- relates to
-
SIO-1607
ForceIPDNSAuth middleware is still active after end of contest exclusiveness
-
Activity
Jakub Bartmiński
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Jakub Bartmiński [ xvyx ] |
Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 5
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 5
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 5
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 6
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 6
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 6
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 8
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 8
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 8
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 9
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 9
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 9
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 10
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 10
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 10
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 11
https://gerrit.sio2project.mimuw.edu.pl/3137
(SIO-1890) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
https://gerrit.sio2project.mimuw.edu.pl/3137
(
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 11
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
Gerrit Gerrit
added a comment - Change oioioi~master~I493c27f3edfde16fdd80781819e7dcfc06dc51ef, patchset 11
https://gerrit.sio2project.mimuw.edu.pl/3137
( SIO-1890 ) Allow multiple exclusiveness configs
This change should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be safer to have a confirmation dialog instead of a warning but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets, and in
save_formset it's too late to raise validation errors).
This could be done in javascript, but it would be impossible to test it
and as such it could be unsafe to rely on it working properly.
Added the following tests testing this functionality:
- oioioi/contestexcl/tests.py
- class TestExclusiveContestsAdmin:
- test_exclusiveness_multiple_on
- test_exclusiveness_multiple_off
- test_exclusiveness_multiple_mixed_on_off
- test_exclusiveness_round_warning
- test_exclusiveness_round_warning_multiple_configs
- class TestExclusiveContests:
- test_exclusive_contest_multiple_configs
And also refactored other contestexcl tests to avoid repeating code
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef Jakub Bartmiński
made changes -
| Status | New [ 10000 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Jakub Bartmiński
made changes -
Szymon Acedański
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Transition | Time In Source Status | Execution Times | Last Executer | Last Execution Date | |||||
|---|---|---|---|---|---|---|---|---|---|
|
717d 5h 3m | 1 | Jakub Bartmiński | 2019-01-31 16:52 | |||||
|
53d 23h 49m | 1 | Szymon Acedański | 2019-03-26 16:41 |
https://gerrit.sio2project.mimuw.edu.pl/3137
(
SIO-1890) Allow multiple exclusiveness configsThis should allow to define more than one exclusiveness config.
Also displays a warning when a round is set not to be exclusive.
It would be nice to have a confirmation dialog instead of a warning, but
since exclusiveness configs covering every round can change both with
changes to rounds and configs themselves, Django admin makes it
difficult (you can't easily cross-validate different formsets).
This could be done in javascript, but it would be impossible to test it
and as such it could be dangerous to rely on it working properly.
Change-Id: I493c27f3edfde16fdd80781819e7dcfc06dc51ef
TODO: tests
TODO: breaks a test, why even?