The SIO2 project
  1. The SIO2 project
  2. SIO-1607

ForceIPDNSAuth middleware is still active after end of contest exclusiveness

        Details

        • Type: Bug Bug
        • Status: Closed Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: OIOIOI
        • Labels:
          None

          Description

          When you set up a contest of onsite-type, like OI Onsite, the ForceIPDNSAuth middleware will require that the user is authenticated through his/her IP or DNS. But It will behave this way as long as the middleware is included in settings.py, but the intended behavior is to block access only to ongoing contests. This forces (pun intended :P) the admins to comment and uncomment the middleware in the settings.py file.

          I suppose that coupling this middleware with contest-exclusiveness would work as expected, but this idea has to be verified.

            Issue Links

            is related to

            Improvement - An improvement or enhancement to an existing feature or task. SIO-1890 Exclusiveness configs - allow adding many time periods

            • Major - Major loss of function.
            • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Wojciech Dubiel added a comment - - edited
              Regarding coupling this middleware to contest-exclusiveness - looks like this is already implemented:
              https://github.com/sio2project/oioioi/commit/c6bd1d70b3f476fe8538696257727a9f4b8c7719

              And it turnede out to be a bad idea.

              We want to allow users to log in with password in the time between rounds, so that they can check their results.
              Right now, this requires disabling exclusiveness, after each round, and reenabling it for the next round.
              Either this should be decoupled, or multiple exclusiveness configs should be allowd (see
              SIO-1890 )
              Show
              Wojciech Dubiel added a comment - - edited Regarding coupling this middleware to contest-exclusiveness - looks like this is already implemented: https://github.com/sio2project/oioioi/commit/c6bd1d70b3f476fe8538696257727a9f4b8c7719 And it turnede out to be a bad idea. We want to allow users to log in with password in the time between rounds, so that they can check their results. Right now, this requires disabling exclusiveness, after each round, and reenabling it for the next round. Either this should be decoupled, or multiple exclusiveness configs should be allowd (see SIO-1890 )
              Hide
              Permalink
              Jakub Bartmiński added a comment -
              ForceIPDNSAuth had already been coupled with contestexcl at some point in the past, and as per Wojtek's suggestion I added the option of multiple contestexcl configs, which should resolve the issue for now. Reopen if need be.
              Show
              Jakub Bartmiński added a comment - ForceIPDNSAuth had already been coupled with contestexcl at some point in the past, and as per Wojtek's suggestion I added the option of multiple contestexcl configs, which should resolve the issue for now. Reopen if need be.

                People

                • Assignee:
                  Szymon Acedański
                  Reporter:
                  Maciej Matraszek
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: