The SIO2 project
  1. The SIO2 project
  2. SIO-1842

Ellipsis in an inline image in CSS -- breaks admin pages

        Details

        • Type: Bug Bug
        • Status: Closed Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: OIOIOI
        • Labels:
        • Environment:
          Production deployment (sio2.mimuw.edu.pl)

          Description

          A recent fix to admin stylesheets introduced a strange piece of code:
          At
          https://github.com/sio2project/oioioi/commit/7bfcfbced8fc28345a160bbc8ecff6b9509385d3#diff-c22ed5025698002d37660dcf8ddb173bR150
          :
          background-image: url('data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgi…pZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9InVybCgjZ3JhZCkiIC8+PC9zdmc+IA==');

          Yes, it has an ellipsis in the middle! It breaks the JS/CSS compression on oioioi deployments, and therefore breaks admin pages.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Iefab6cefd65ebc79f33e625b16d2ebc90eeda291, patchset 1
            https://gerrit.sio2project.mimuw.edu.pl/2623

            SIO-1842 Ellipsis in an inline image in CSS -- breaks admin pages

            removed unnecessery styles (gradient and -webkit-gradient is supported by all browsers no need for extra inline svg)

            Change-Id: Iefab6cefd65ebc79f33e625b16d2ebc90eeda291
            Show
            Gerrit Gerrit added a comment - Change Iefab6cefd65ebc79f33e625b16d2ebc90eeda291, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/2623 SIO-1842 Ellipsis in an inline image in CSS -- breaks admin pages removed unnecessery styles (gradient and -webkit-gradient is supported by all browsers no need for extra inline svg) Change-Id: Iefab6cefd65ebc79f33e625b16d2ebc90eeda291
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Iefab6cefd65ebc79f33e625b16d2ebc90eeda291, patchset 2
            https://gerrit.sio2project.mimuw.edu.pl/2623

            SIO-1842 Ellipsis in an inline image in CSS -- breaks admin pages

            removed unnecessery styles (gradient and -webkit-gradient is supported by all
            browsers no need for extra inline svg)

            Change-Id: Iefab6cefd65ebc79f33e625b16d2ebc90eeda291
            Show
            Gerrit Gerrit added a comment - Change Iefab6cefd65ebc79f33e625b16d2ebc90eeda291, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/2623 SIO-1842 Ellipsis in an inline image in CSS -- breaks admin pages removed unnecessery styles (gradient and -webkit-gradient is supported by all browsers no need for extra inline svg) Change-Id: Iefab6cefd65ebc79f33e625b16d2ebc90eeda291

              People

              • Assignee:
                Mikołaj Walczak
                Reporter:
                Maciej Matraszek
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: