The SIO2 project
  1. The SIO2 project
  2. SIO-2492

Translated strings which end with a space.

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: None
    • Component/s: OIOIOI
    • Labels:
      None
    • Sprint:
      TAG 2021/22 Summer Sprint 1

      Description

      Some of strings translated in OIOIOI end with a space, which is very hard to notice in Transifex and can lead to errors such as this in a screenshot.

        Activity

        Mieszko Grodzicki made changes -
        Field Original Value New Value
        Rank Ranked higher
        Mieszko Grodzicki made changes -
        Sprint TAG 2021/22 Summer Sprint 1 [ 8 ]
        Mieszko Grodzicki made changes -
        Rank Ranked lower
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564, patchset 1
        https://gerrit.sio2project.mimuw.edu.pl/3814

        SIO-2492 Remove ending whitespaces from translated strings.

        Change-Id: Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3814 SIO-2492 Remove ending whitespaces from translated strings. Change-Id: Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564
        Hide
        Tomek Waleń added a comment -
        In most cases white-spaces are due to concatenation of translated string with template variable.
        We can use blocktrans in such case, i.e.:
        ```
        {% blocktrans %}Please visit {{ msg_link }} to answer it.{% endblocktrans %}
        ```

        The same applies to _ in python code, i.e.
        ```
        _("Start of %s") % obj.name)
        ```
        instead of
        ```
        _("Start of") + " " + obj.name)
        ```
        Show
        Tomek Waleń added a comment - In most cases white-spaces are due to concatenation of translated string with template variable. We can use blocktrans in such case, i.e.: ``` {% blocktrans %}Please visit {{ msg_link }} to answer it.{% endblocktrans %} ``` The same applies to _ in python code, i.e. ``` _("Start of %s") % obj.name) ``` instead of ``` _("Start of") + " " + obj.name) ```
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564, patchset 2
        https://gerrit.sio2project.mimuw.edu.pl/3814

        SIO-2492 Remove ending whitespaces from translated strings.

        Change-Id: Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3814 SIO-2492 Remove ending whitespaces from translated strings. Change-Id: Ib25a4c5f3f50a6690b44f9ed1b8688eae8688564
        Mieszko Grodzicki made changes -
        Status New [ 10000 ] Resolved [ 5 ]
        Assignee Tomasz Waleń [ tomasz_walen ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        New New Resolved Resolved
        5d 9h 53m 1 Mieszko Grodzicki 2022-03-26 22:56

          People

          • Assignee:
            Tomasz Waleń
            Reporter:
            Mieszko Grodzicki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile