The SIO2 project
  1. The SIO2 project
  2. SIO-2488

Make tests work with apostrophe encoded as both ''' and '''.

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: None
    • Component/s: OIOIOI
    • Labels:
      None

      Description

      Currently some of tests checking whether response contains a phrase with an apostrophe assume that is encoded by ''' (or before upgrade to Django 3.0 - '''). It would be better to improve these tests so that they work without making such assumption.

        Activity

        Mieszko Grodzicki made changes -
        Field Original Value New Value
        Rank Ranked higher
        Kacper Lewandowski made changes -
        Assignee Kacper Lewandowski [ kl429158 ]
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Ife3c7458a81c37ca575ccc8d823b47382686dcc0, patchset 1
        https://gerrit.sio2project.mimuw.edu.pl/3812

        SIO-2488 Escaping apostrophes in tests.

        Currently apostrophes are escaped manually in some tests.
        After this change django.utils.html.escape is called instead.

        Change-Id: Ife3c7458a81c37ca575ccc8d823b47382686dcc0
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Ife3c7458a81c37ca575ccc8d823b47382686dcc0, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3812 SIO-2488 Escaping apostrophes in tests. Currently apostrophes are escaped manually in some tests. After this change django.utils.html.escape is called instead. Change-Id: Ife3c7458a81c37ca575ccc8d823b47382686dcc0
        Hide
        Tomek Waleń added a comment -
        Django 2.2 was using internal escaping method (https://docs.djangoproject.com/pl/2.2/_modules/django/utils/html/) and in Django 3.0 python html.escape is used (https://docs.djangoproject.com/pl/3.0/_modules/django/utils/html/)
        Show
        Tomek Waleń added a comment - Django 2.2 was using internal escaping method ( https://docs.djangoproject.com/pl/2.2/_modules/django/utils/html/ ) and in Django 3.0 python html.escape is used ( https://docs.djangoproject.com/pl/3.0/_modules/django/utils/html/ )
        Tomek Waleń made changes -
        Status New [ 10000 ] Resolved [ 5 ]
        Assignee Kacper Lewandowski [ kl429158 ] Tomasz Waleń [ tomasz_walen ]
        Resolution Fixed [ 1 ]
        Tomek Waleń made changes -
        Assignee Tomasz Waleń [ tomasz_walen ] Kacper Lewandowski [ kl429158 ]
        TAG Developer Kacper Lewandowski [ kl429158 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        New New Resolved Resolved
        12d 14h 24m 1 Tomek Waleń 2022-03-28 10:50

          People

          • Assignee:
            Kacper Lewandowski
            Reporter:
            Mieszko Grodzicki
            TAG Developer:
            Kacper Lewandowski
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: