The SIO2 project
  1. The SIO2 project
  2. SIO-2399

Configure Black as our new code formatter and reformat the oioioi codebase

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: TAG 2020/21 Winter Sprint
    • Component/s: OIOIOI
    • Labels:
      None
    • Sprint:
      TAG 2020/21 Winter Sprint

      Description

      Konieczne:

      1. Dodanie Blacka do staticznej analizy z poprawnym konfigiem (ignorowanie migracji, ignorowanie zmian apostrofów i cudzysłowów; konfig nie może się gryźć z pylintem)
      2. Sformatowanie kodu Blackiem
      3. Ustawienie ignore ref na commit formatujący, żeby nie zepsuć git blame

        Activity

        Jakub Moliński made changes -
        Field Original Value New Value
        Assignee Jakub Moliński [ jmolinski ]
        Wojciech Dubiel made changes -
        Affects Version/s TAG 2020/21 Winter Sprint [ 13100 ]
        Affects Version/s Current Version [ 11000 ]
        Wojciech Dubiel made changes -
        Affects Version/s Current Version [ 11000 ]
        Affects Version/s TAG 2020/21 Winter Sprint [ 13100 ]
        Wojciech Dubiel made changes -
        Fix Version/s TAG 2020/21 Winter Sprint [ 13100 ]
        Wojciech Dubiel made changes -
        Sprint TAG 2020/21 Winter Sprint [ 4 ]
        Wojciech Dubiel made changes -
        Rank Ranked higher
        Jakub Moliński made changes -
        Status New [ 10000 ] Open [ 1 ]
        Jakub Moliński made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 1
        https://gerrit.sio2project.mimuw.edu.pl/3577

        (SIO-2399) Black and isort bulk reformat

        This commit contains a bulk reformat of all the files in oioioi
        directory. The tools used for reformatting were black and isort. This
        commit should be ignored from git blame. The config files for black and
        isort will be included in a subsequent commit so that they are not
        excluded from git blame.

        Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3577 ( SIO-2399 ) Black and isort bulk reformat This commit contains a bulk reformat of all the files in oioioi directory. The tools used for reformatting were black and isort. This commit should be ignored from git blame. The config files for black and isort will be included in a subsequent commit so that they are not excluded from git blame. Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 2
        https://gerrit.sio2project.mimuw.edu.pl/3577

        (SIO-2399) Black and isort bulk reformat

        This commit contains a bulk reformat of all the files in oioioi
        directory. The tools used for reformatting were black and isort. This
        commit should be ignored from git blame. The config files for black and
        isort will be included in a subsequent commit so that they are not
        excluded from git blame.

        Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3577 ( SIO-2399 ) Black and isort bulk reformat This commit contains a bulk reformat of all the files in oioioi directory. The tools used for reformatting were black and isort. This commit should be ignored from git blame. The config files for black and isort will be included in a subsequent commit so that they are not excluded from git blame. Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 3
        https://gerrit.sio2project.mimuw.edu.pl/3577

        (SIO-2399) Black and isort bulk reformat

        This commit contains a bulk reformat of all the files in oioioi
        directory. The tools used for reformatting were black and isort. This
        commit should be ignored from git blame. The config files for black and
        isort will be included in a subsequent commit so that they are not
        excluded from git blame.

        Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/3577 ( SIO-2399 ) Black and isort bulk reformat This commit contains a bulk reformat of all the files in oioioi directory. The tools used for reformatting were black and isort. This commit should be ignored from git blame. The config files for black and isort will be included in a subsequent commit so that they are not excluded from git blame. Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 4
        https://gerrit.sio2project.mimuw.edu.pl/3577

        (SIO-2399) Black and isort bulk reformat

        This commit contains a bulk reformat of all the files in oioioi
        directory. The tools used for reformatting were black and isort. This
        commit should be ignored from git blame. The config files for black and
        isort will be included in a subsequent commit so that they are not
        excluded from git blame.

        Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/3577 ( SIO-2399 ) Black and isort bulk reformat This commit contains a bulk reformat of all the files in oioioi directory. The tools used for reformatting were black and isort. This commit should be ignored from git blame. The config files for black and isort will be included in a subsequent commit so that they are not excluded from git blame. Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 5
        https://gerrit.sio2project.mimuw.edu.pl/3577

        (SIO-2399) Black and isort bulk reformat

        This commit contains a bulk reformat of all the files in oioioi
        directory. The tools used for reformatting were black and isort. This
        commit should be ignored from git blame. The config files for black and
        isort will be included in a subsequent commit so that they are not
        excluded from git blame.

        Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 5 https://gerrit.sio2project.mimuw.edu.pl/3577 ( SIO-2399 ) Black and isort bulk reformat This commit contains a bulk reformat of all the files in oioioi directory. The tools used for reformatting were black and isort. This commit should be ignored from git blame. The config files for black and isort will be included in a subsequent commit so that they are not excluded from git blame. Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 1
        https://gerrit.sio2project.mimuw.edu.pl/3578

        (SIO-2399) Update static analysis config files

        Adds new configs for black and isort and updates configs for pep8 and
        pylint.
        Adds .git-blame-ignore-revs file that containts ref numbers of commits
        that should be ignored by git blame.

        It may be necessary to run
        git config blame.ignoreRevsFile .git-blame-ignore-revs
        for git to always respect this config when running blame.

        Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3578 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 2
        https://gerrit.sio2project.mimuw.edu.pl/3578

        (SIO-2399) Update static analysis config files

        Adds new configs for black and isort and updates configs for pep8 and
        pylint.
        Adds .git-blame-ignore-revs file that containts ref numbers of commits
        that should be ignored by git blame.

        It may be necessary to run
        git config blame.ignoreRevsFile .git-blame-ignore-revs
        for git to always respect this config when running blame.

        Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3578 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 3
        https://gerrit.sio2project.mimuw.edu.pl/3578

        (SIO-2399) Update static analysis config files

        Adds new configs for black and isort and updates configs for pep8 and
        pylint.
        Adds .git-blame-ignore-revs file that containts ref numbers of commits
        that should be ignored by git blame.

        It may be necessary to run
        git config blame.ignoreRevsFile .git-blame-ignore-revs
        for git to always respect this config when running blame.

        Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/3578 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 4
        https://gerrit.sio2project.mimuw.edu.pl/3578

        (SIO-2399) Update static analysis config files

        Adds new configs for black and isort and updates configs for pep8 and
        pylint.
        Adds .git-blame-ignore-revs file that containts ref numbers of commits
        that should be ignored by git blame.

        It may be necessary to run
        git config blame.ignoreRevsFile .git-blame-ignore-revs
        for git to always respect this config when running blame.

        Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/3578 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 6
        https://gerrit.sio2project.mimuw.edu.pl/3577

        (SIO-2399) Black and isort bulk reformat

        This commit contains a bulk reformat of all the files in oioioi
        directory. The tools used for reformatting were black and isort. This
        commit should be ignored from git blame. The config files for black and
        isort will be included in a subsequent commit so that they are not
        excluded from git blame.

        Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 6 https://gerrit.sio2project.mimuw.edu.pl/3577 ( SIO-2399 ) Black and isort bulk reformat This commit contains a bulk reformat of all the files in oioioi directory. The tools used for reformatting were black and isort. This commit should be ignored from git blame. The config files for black and isort will be included in a subsequent commit so that they are not excluded from git blame. Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
        Hide
        Gerrit Gerrit added a comment -
        Change oioioi~master~I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422, patchset 1
        https://gerrit.sio2project.mimuw.edu.pl/3579

        (SIO-2399) Update static analysis config files

        Adds new configs for black and isort and updates configs for pep8 and
        pylint.
        Adds .git-blame-ignore-revs file that containts ref numbers of commits
        that should be ignored by git blame.

        It may be necessary to run
        git config blame.ignoreRevsFile .git-blame-ignore-revs
        for git to always respect this config when running blame.

        Change-Id: I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422
        Show
        Gerrit Gerrit added a comment - Change oioioi~master~I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3579 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422
        Jakub Moliński made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Assignee Jakub Moliński [ jmolinski ] Wojciech Dubiel [ wolf480 ]
        Resolution Fixed [ 1 ]
        Hide
        Jakub Moliński added a comment -
        This is a duplicate od (SIO-2397) which should be closed now as this has been resolved
        Show
        Jakub Moliński added a comment - This is a duplicate od ( SIO-2397 ) which should be closed now as this has been resolved
        Jakub Moliński made changes -
        Summary Skonfigurowanie Blacka i sformatowanie istniejącego kodu Confu
        Jakub Moliński made changes -
        Summary Confu Configure Black as our new code formatter and reformat the oioioi codebase
        Jakub Moliński made changes -
        Assignee Wojciech Dubiel [ wolf480 ] Jakub Moliński [ jmolinski ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        New New Open Open
        2d 11h 34m 1 Jakub Moliński 2021-01-11 2:27
        Open Open In Progress In Progress
        4s 1 Jakub Moliński 2021-01-11 2:27
        In Progress In Progress Resolved Resolved
        1d 14h 26m 1 Jakub Moliński 2021-01-12 16:54

          People

          • Assignee:
            Jakub Moliński
            Reporter:
            Jakub Moliński
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile