The SIO2 project
  1. The SIO2 project
  2. SIO-2399

Configure Black as our new code formatter and reformat the oioioi codebase

        Details

        • Type: Improvement Improvement
        • Status: Resolved Resolved
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: TAG 2020/21 Winter Sprint
        • Component/s: OIOIOI
        • Labels:
          None
        • Sprint:
          TAG 2020/21 Winter Sprint

          Description

          Konieczne:

          1. Dodanie Blacka do staticznej analizy z poprawnym konfigiem (ignorowanie migracji, ignorowanie zmian apostrofów i cudzysłowów; konfig nie może się gryźć z pylintem)
          2. Sformatowanie kodu Blackiem
          3. Ustawienie ignore ref na commit formatujący, żeby nie zepsuć git blame

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 3
            https://gerrit.sio2project.mimuw.edu.pl/3578

            (SIO-2399) Update static analysis config files

            Adds new configs for black and isort and updates configs for pep8 and
            pylint.
            Adds .git-blame-ignore-revs file that containts ref numbers of commits
            that should be ignored by git blame.

            It may be necessary to run
            git config blame.ignoreRevsFile .git-blame-ignore-revs
            for git to always respect this config when running blame.

            Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/3578 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 4
            https://gerrit.sio2project.mimuw.edu.pl/3578

            (SIO-2399) Update static analysis config files

            Adds new configs for black and isort and updates configs for pep8 and
            pylint.
            Adds .git-blame-ignore-revs file that containts ref numbers of commits
            that should be ignored by git blame.

            It may be necessary to run
            git config blame.ignoreRevsFile .git-blame-ignore-revs
            for git to always respect this config when running blame.

            Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~I2690a18d3119ebe1b33b1d42c0243402885c52f4, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/3578 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I2690a18d3119ebe1b33b1d42c0243402885c52f4
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 6
            https://gerrit.sio2project.mimuw.edu.pl/3577

            (SIO-2399) Black and isort bulk reformat

            This commit contains a bulk reformat of all the files in oioioi
            directory. The tools used for reformatting were black and isort. This
            commit should be ignored from git blame. The config files for black and
            isort will be included in a subsequent commit so that they are not
            excluded from git blame.

            Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~Iac7b2e474534d1700234e798e73bd464ffe6f517, patchset 6 https://gerrit.sio2project.mimuw.edu.pl/3577 ( SIO-2399 ) Black and isort bulk reformat This commit contains a bulk reformat of all the files in oioioi directory. The tools used for reformatting were black and isort. This commit should be ignored from git blame. The config files for black and isort will be included in a subsequent commit so that they are not excluded from git blame. Change-Id: Iac7b2e474534d1700234e798e73bd464ffe6f517
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422, patchset 1
            https://gerrit.sio2project.mimuw.edu.pl/3579

            (SIO-2399) Update static analysis config files

            Adds new configs for black and isort and updates configs for pep8 and
            pylint.
            Adds .git-blame-ignore-revs file that containts ref numbers of commits
            that should be ignored by git blame.

            It may be necessary to run
            git config blame.ignoreRevsFile .git-blame-ignore-revs
            for git to always respect this config when running blame.

            Change-Id: I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3579 ( SIO-2399 ) Update static analysis config files Adds new configs for black and isort and updates configs for pep8 and pylint. Adds .git-blame-ignore-revs file that containts ref numbers of commits that should be ignored by git blame. It may be necessary to run git config blame.ignoreRevsFile .git-blame-ignore-revs for git to always respect this config when running blame. Change-Id: I9645a2d9a8772e92bf99ce9fbaa6a98a0c94b422
            Hide
            Permalink
            Jakub Moliński added a comment -
            This is a duplicate od (SIO-2397) which should be closed now as this has been resolved
            Show
            Jakub Moliński added a comment - This is a duplicate od ( SIO-2397 ) which should be closed now as this has been resolved

              People

              • Assignee:
                Jakub Moliński
                Reporter:
                Jakub Moliński
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Agile