Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Duplicate
-
Affects Version/s: Current Version
-
Fix Version/s: None
-
Component/s: Zzz! / None of the above / I really don't know
-
Labels:None
Description
For a year or two, the pylint hooks on gerrit weren't working, so a large portion of the code may not be following our code style.
We could use an automated code formatting tool such as "black" or "darker" to reformat that code, and possibly keep code automatically formatted in the future.
However, our project has a few peculiar conventions, such as the distinction between single and double quotes. It'd be better if we could keep them, so code formatting tools may need some special configuration for this.
Also, if we were to do code formatting when unrelated changes are being made, care must be taken to keep the diffs readable.
We could use an automated code formatting tool such as "black" or "darker" to reformat that code, and possibly keep code automatically formatted in the future.
However, our project has a few peculiar conventions, such as the distinction between single and double quotes. It'd be better if we could keep them, so code formatting tools may need some special configuration for this.
Also, if we were to do code formatting when unrelated changes are being made, care must be taken to keep the diffs readable.
Activity
Jakub Moliński
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Status | New [ 10000 ] | Resolved [ 5 ] |
| Assignee | Wojciech Dubiel [ wolf480 ] | |
| Resolution | Duplicate [ 3 ] |
Paweł Dietrich
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Transition | Time In Source Status | Execution Times | Last Executer | Last Execution Date | |||||
|---|---|---|---|---|---|---|---|---|---|
|
88d 3h 53m | 1 | Jakub Moliński | 2021-03-14 16:16 | |||||
|
250d 1h 34m | 1 | Paweł Dietrich | 2021-11-19 17:50 |
SIO-2399) which has been resolved so this should probably be resolved or closed