The SIO2 project
  1. The SIO2 project
  2. SIO-2317

Fix urls in problemset with custom GET parameters in URLs

        Details

        • Type: Bug Bug
        • Status: Resolved Resolved
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: OIOIOI
        • Labels:

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SIO-2291 Misc. UX improvements (meta-ticket)

          • Major - Major loss of function.
          • Open - The issue is open and ready for the assignee to start work on it.

            Activity

            Ascending order - Click to sort in descending order
            Szymon Acedański made changes -
            Field Original Value New Value
            Labels tag1
            Szymon Acedański made changes -
            Link This issue relates to SIO-2291 [ SIO-2291 ]
            Hubert Badocha made changes -
            Assignee Hubert Badocha [ badochov ]
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 1
            https://gerrit.sio2project.mimuw.edu.pl/3551

            SIO-2317 Fix urls in problemset with custom GET parameters in URLs

            As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there.

            Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3551 SIO-2317 Fix urls in problemset with custom GET parameters in URLs As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there. Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 2
            https://gerrit.sio2project.mimuw.edu.pl/3551

            SIO-2317 Fix urls in problemset with custom GET parameters in URLs

            As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there.

            Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3551 SIO-2317 Fix urls in problemset with custom GET parameters in URLs As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there. Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~I591da4c74a7d87f49f8c22a682796e81ae0e09e4, patchset 1
            https://gerrit.sio2project.mimuw.edu.pl/3553

            SIO-2317 Fix urls in problemset with custom GET parameters in URLs

            As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there.

            Change-Id: I591da4c74a7d87f49f8c22a682796e81ae0e09e4
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~I591da4c74a7d87f49f8c22a682796e81ae0e09e4, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3553 SIO-2317 Fix urls in problemset with custom GET parameters in URLs As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there. Change-Id: I591da4c74a7d87f49f8c22a682796e81ae0e09e4
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 3
            https://gerrit.sio2project.mimuw.edu.pl/3551

            SIO-2317 Fix urls in problemset with custom GET parameters in URLs

            As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there.

            Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/3551 SIO-2317 Fix urls in problemset with custom GET parameters in URLs As this pages checks GET parameters for validation of request I removed fbclid id from parameters if it is there. Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 4
            https://gerrit.sio2project.mimuw.edu.pl/3551

            SIO-2317 Fix urls in problemset with custom GET parameters in URLs

            As this pages checks GET parameters for validation of request I added filter method that doesn't pass fbclid from parameters if it is there.
            I added twi test cases and formated views.py to follow pep8 using pycharm default formatter.

            Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/3551 SIO-2317 Fix urls in problemset with custom GET parameters in URLs As this pages checks GET parameters for validation of request I added filter method that doesn't pass fbclid from parameters if it is there. I added twi test cases and formated views.py to follow pep8 using pycharm default formatter. Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 5
            https://gerrit.sio2project.mimuw.edu.pl/3551

            SIO-2317 Fix urls in problemset with custom GET parameters in URLs

            As this pages checks GET parameters for validation of request I added filter method that doesn't pass fbclid from parameters if it is there.
            I added two test cases.

            Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556, patchset 5 https://gerrit.sio2project.mimuw.edu.pl/3551 SIO-2317 Fix urls in problemset with custom GET parameters in URLs As this pages checks GET parameters for validation of request I added filter method that doesn't pass fbclid from parameters if it is there. I added two test cases. Change-Id: Icc7dbf6b60ad44cb5455fe76bdd250f2a46ee556
            Hubert Badocha made changes -
            Status New [ 10000 ] Resolved [ 5 ]
            Assignee Hubert Badocha [ badochov ] Wojciech Dubiel [ wolf480 ]
            Resolution Fixed [ 1 ]
            Transition Time In Source Status Execution Times Last Executer Last Execution Date
            New New Resolved Resolved
            		376d 16h 40m 1 Hubert Badocha 2021-01-8 14:32

              People

              • Assignee:
                Wojciech Dubiel
                Reporter:
                Bartosz Kostka
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: