The SIO2 project
  1. The SIO2 project
  2. SIO-2297

When adding new question to a quiz, rejudging old submissions breaks them

        Details

        • Type: Bug Bug
        • Status: Resolved Resolved
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: Evaluation Engine / Workers
        • Labels:

          Description

          When a new question is added to a quiz, and then rejudging old submittions to the same quiz, a crash will occur and these submissions will corrupt (making them impossible to view without a crash).
          Probably the same will happen, if we remove or significantly change a question (though I didn't test that)

            Issue Links

            relates to

            Bug - A problem which impairs or prevents the functions of the product. SIO-2295 Multiple minor bugs in quizzes (meta-ticket)

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

              Activity

              Ascending order - Click to sort in descending order
              Stanisław Strzelecki made changes -
              Field Original Value New Value
              Link This issue relates to SIO-2295 [ SIO-2295 ]
              Szymon Acedański made changes -
              Labels tag1
              Hubert Badocha made changes -
              Assignee Hubert Badocha [ badochov ]
              Hubert Badocha made changes -
              Assignee Hubert Badocha [ badochov ]
              Szymon Czyżmański made changes -
              Assignee Szymon Czyżmański [ czyzmanski ]
              Szymon Czyżmański made changes -
              Status New [ 10000 ] Open [ 1 ]
              Szymon Czyżmański made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change oioioi~master~I981005ca9601833e24490ea88190feaa92e8a44b, patchset 1
              https://gerrit.sio2project.mimuw.edu.pl/3568

              SIO-2297 When adding new question to a quiz, rejudging old submissions breaks them

              I modified method responsible for scoring quiz, as well as method for scoring
              question so that it is checked if any answer was submitted for a particular question.
              If there is no submitted answer, then such question is ignored and not counted to
              the overall quiz score.
              I added two test cases for rejudging quiz after adding new questions.

              Change-Id: I981005ca9601833e24490ea88190feaa92e8a44b
              Show
              Gerrit Gerrit added a comment - Change oioioi~master~I981005ca9601833e24490ea88190feaa92e8a44b, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3568 SIO-2297 When adding new question to a quiz, rejudging old submissions breaks them I modified method responsible for scoring quiz, as well as method for scoring question so that it is checked if any answer was submitted for a particular question. If there is no submitted answer, then such question is ignored and not counted to the overall quiz score. I added two test cases for rejudging quiz after adding new questions. Change-Id: I981005ca9601833e24490ea88190feaa92e8a44b
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change oioioi~master~I46e1b0df201654ea9ea5197ea5d519bed34b32b1, patchset 2
              https://gerrit.sio2project.mimuw.edu.pl/3566

              SIO-2297 When adding new question to a quiz, rejudging old submissions breaks them

              I modified method responsible for scoring quiz, as well as method for scoring
              question so that it is checked if any answer was submitted for a particular question.
              If there is no submitted answer, then such question is ignored and not counted to
              the overall quiz score.
              I added two test cases for rejudging quiz after adding new questions.

              Change-Id: I46e1b0df201654ea9ea5197ea5d519bed34b32b1
              Show
              Gerrit Gerrit added a comment - Change oioioi~master~I46e1b0df201654ea9ea5197ea5d519bed34b32b1, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3566 SIO-2297 When adding new question to a quiz, rejudging old submissions breaks them I modified method responsible for scoring quiz, as well as method for scoring question so that it is checked if any answer was submitted for a particular question. If there is no submitted answer, then such question is ignored and not counted to the overall quiz score. I added two test cases for rejudging quiz after adding new questions. Change-Id: I46e1b0df201654ea9ea5197ea5d519bed34b32b1
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change oioioi~master~I2aaab25adb2182b98ce1333b2a0d86d9b84aa987, patchset 1
              https://gerrit.sio2project.mimuw.edu.pl/3569

              SIO-2297 When adding new question to a quiz, rejudging old submissions breaks them

              I modified method responsible for scoring quiz, as well as method for scoring
              question so that it is checked if any answer was submitted for a particular question.
              If there is no submitted answer, then such question is ignored and not counted to
              the overall quiz score.
              I added two test cases for rejudging quiz after adding new questions.

              Change-Id: I2aaab25adb2182b98ce1333b2a0d86d9b84aa987
              Show
              Gerrit Gerrit added a comment - Change oioioi~master~I2aaab25adb2182b98ce1333b2a0d86d9b84aa987, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3569 SIO-2297 When adding new question to a quiz, rejudging old submissions breaks them I modified method responsible for scoring quiz, as well as method for scoring question so that it is checked if any answer was submitted for a particular question. If there is no submitted answer, then such question is ignored and not counted to the overall quiz score. I added two test cases for rejudging quiz after adding new questions. Change-Id: I2aaab25adb2182b98ce1333b2a0d86d9b84aa987
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change oioioi~master~Idc4c0452b6bce4494b050dcdb22fa37a261d7820, patchset 1
              https://gerrit.sio2project.mimuw.edu.pl/3570

              SIO-2297 Fixed bug with rejudging old submissions after adding new questions to a quiz

              I modified method responsible for scoring quiz, as well as method for scoring
              question so that it is checked if any answer was submitted for a particular question.
              If there is no submitted answer, then such question is ignored and not counted to
              the overall quiz score.
              I added two test cases for rejudging quiz after adding new questions to it.

              Change-Id: Idc4c0452b6bce4494b050dcdb22fa37a261d7820
              Show
              Gerrit Gerrit added a comment - Change oioioi~master~Idc4c0452b6bce4494b050dcdb22fa37a261d7820, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3570 SIO-2297 Fixed bug with rejudging old submissions after adding new questions to a quiz I modified method responsible for scoring quiz, as well as method for scoring question so that it is checked if any answer was submitted for a particular question. If there is no submitted answer, then such question is ignored and not counted to the overall quiz score. I added two test cases for rejudging quiz after adding new questions to it. Change-Id: Idc4c0452b6bce4494b050dcdb22fa37a261d7820
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change oioioi~master~Idc4c0452b6bce4494b050dcdb22fa37a261d7820, patchset 2
              https://gerrit.sio2project.mimuw.edu.pl/3570

              SIO-2297 Fixed bug with rejudging old submissions after adding new questions to a quiz

              I modified method responsible for scoring quiz, as well as method for scoring
              question so that it is checked if any answer was submitted for a particular question.
              If there is no submitted answer, then such question is ignored and not counted to
              the overall quiz score.
              I added two test cases for rejudging quiz after adding new questions to it.

              Change-Id: Idc4c0452b6bce4494b050dcdb22fa37a261d7820
              Show
              Gerrit Gerrit added a comment - Change oioioi~master~Idc4c0452b6bce4494b050dcdb22fa37a261d7820, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/3570 SIO-2297 Fixed bug with rejudging old submissions after adding new questions to a quiz I modified method responsible for scoring quiz, as well as method for scoring question so that it is checked if any answer was submitted for a particular question. If there is no submitted answer, then such question is ignored and not counted to the overall quiz score. I added two test cases for rejudging quiz after adding new questions to it. Change-Id: Idc4c0452b6bce4494b050dcdb22fa37a261d7820
              Hide
              Permalink
              Szymon Czyżmański added a comment -
              Fixed and merged to master
              Show
              Szymon Czyżmański added a comment - Fixed and merged to master
              Szymon Czyżmański made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Assignee Szymon Czyżmański [ czyzmanski ] Wojciech Dubiel [ wolf480 ]
              Resolution Fixed [ 1 ]
              Transition Time In Source Status Execution Times Last Executer Last Execution Date
              New New Open Open
              		375d 23h 20m 1 Szymon Czyżmański 2020-11-30 17:08
              Open Open In Progress In Progress
              		3s 1 Szymon Czyżmański 2020-11-30 17:08
              In Progress In Progress Resolved Resolved
              		14d 19h 45m 1 Szymon Czyżmański 2020-12-15 12:54

                People

                • Assignee:
                  Wojciech Dubiel
                  Reporter:
                  Stanisław Strzelecki
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: