Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: Current Version
-
Fix Version/s: TAG 2019/20 Sprint 1
-
Component/s: OIOIOI, Translations
Description
It is in Polish even when the selected language is English.
Activity
Zuzanna Opała
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Labels | easy |
Szymon Acedański
made changes -
| Labels | easy | easy tag1 |
Szymon Acedański
made changes -
| Priority | Major [ 3 ] | Minor [ 4 ] |
Szymon Acedański
made changes -
| Assignee | Cezary Chodun [ cezary ] |
Szymon Acedański
made changes -
| TAG Developer | Cezary Chodun [ cezary ] |
Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
In my local sio copy it appeared English even if language was set to Polish.
Hopefully my change fixes both problems.
Modifying navbar registry happens once during the initialization,
so these texts are saved once in the init, therefor only one translation happens.
When changing the language, no modification is possible to these strings.
Added translation in reading these texts from registry,
making sure they get translated every time they are loaded.
Removed translation from regiter functions,
so that registered textx is the text to be translated.
By doing so, I am sure that the text won't get translated before adding,
because the it would not be ever translated back.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
https://gerrit.sio2project.mimuw.edu.pl/3346
In my local sio copy it appeared English even if language was set to Polish.
Hopefully my change fixes both problems.
Modifying navbar registry happens once during the initialization,
so these texts are saved once in the init, therefor only one translation happens.
When changing the language, no modification is possible to these strings.
Added translation in reading these texts from registry,
making sure they get translated every time they are loaded.
Removed translation from regiter functions,
so that registered textx is the text to be translated.
By doing so, I am sure that the text won't get translated before adding,
because the it would not be ever translated back.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
In my local sio copy it appeared English even if language was set to Polish.
Hopefully my change fixes both problems.
Modifying navbar registry happens once during the initialization,
so these texts are saved once in the init, therefor only one translation happens.
When changing the language, no modification is possible to these strings.
Added translation in reading these texts from registry,
making sure they get translated every time they are loaded.
Removed translation from regiter functions,
so that registered textx is the text to be translated.
By doing so, I am sure that the text won't get translated before adding,
because the it would not be ever translated back.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
In my local sio copy it appeared English even if language was set to Polish.
Hopefully my change fixes both problems.
Modifying navbar registry happens once during the initialization,
so these texts are saved once in the init, therefor only one translation happens.
When changing the language, no modification is possible to these strings.
Added translation in reading these texts from registry,
making sure they get translated every time they are loaded.
Removed translation from regiter functions,
so that registered textx is the text to be translated.
By doing so, I am sure that the text won't get translated before adding,
because the it would not be ever translated back.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64 
Stanisław Strzelecki
made changes -
| Assignee | Cezary Chodun [ cezary ] | Stanisław Strzelecki [ stasio6 ] |
Stanisław Strzelecki
made changes -
| Fix Version/s | Current Version [ 11000 ] | |
| TAG Developer | Cezary Chodun [ cezary ] | Stanisław Strzelecki [ stasio6 ] |
| Priority | Minor [ 4 ] | Major [ 3 ] |
| Due Date | 2019-12-11 | |
| Component/s | Translations [ 10120 ] |
Stanisław Strzelecki
made changes -
| Fix Version/s | TAG 2019/20 Sprint 1 [ 13000 ] | |
| Fix Version/s | Current Version [ 11000 ] |
Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
https://gerrit.sio2project.mimuw.edu.pl/3346
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64 Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
https://gerrit.sio2project.mimuw.edu.pl/3346
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64 Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 5
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
https://gerrit.sio2project.mimuw.edu.pl/3346
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 5
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 5
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64 Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 6
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
https://gerrit.sio2project.mimuw.edu.pl/3346
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 6
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 6
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Not sure why that happened, but it's fixed now.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64 Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Probably szkopul loaded navbar view in problemset from normal sio2 view.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
https://gerrit.sio2project.mimuw.edu.pl/3346
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Probably szkopul loaded navbar view in problemset from normal sio2 view.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Show
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Probably szkopul loaded navbar view in problemset from normal sio2 view.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64
Gerrit Gerrit
added a comment - Change oioioi~master~I0661b460c2cdf8fd48c8932dc25e0010e78a1e64, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278 Navbar translations doesn't work in problemset
Translation was imported as ugettext, which was a not lazy version of translation.
Therefor, the translation was made on init, so the text once translated never changed.
Edited import to ugettext_lazy, so that the translation is lazy.
Changed jsonify functions, because they don't accept lazy translation objects.
Before jsonifying results, translated texts to current language.
Added a regression test.
What's interesting, that a bug in problems' view caused an error in szkopul view...
Probably szkopul loaded navbar view in problemset from normal sio2 view.
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64 Szymon Acedański
made changes -
| Status | New [ 10000 ] | Resolved [ 5 ] |
| Assignee | Stanisław Strzelecki [ stasio6 ] | Szymon Acedański [ accek ] |
| Resolution | Fixed [ 1 ] |
Szymon Acedański
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Transition | Time In Source Status | Execution Times | Last Executer | Last Execution Date | |||||
|---|---|---|---|---|---|---|---|---|---|
|
69d 1h 59m | 1 | Szymon Acedański | 2019-12-18 14:18 | |||||
|
76d 1h 50m | 1 | Szymon Acedański | 2020-03-3 16:08 |
https://gerrit.sio2project.mimuw.edu.pl/3346
SIO-2278Navbar translations doesn't work in problemsetIn my local sio copy it appeared English even if language was set to Polish.
Hopefully my change fixes both problems.
Modifying navbar registry happens once during the initialization,
so these texts are saved once in the init, therefor only one translation happens.
When changing the language, no modification is possible to these strings.
Added translation in reading these texts from registry,
making sure they get translated every time they are loaded.
TODO: remove translation from initializing registry!
Change-Id: I0661b460c2cdf8fd48c8932dc25e0010e78a1e64