Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: None
    • Labels:
      None

      Description

      Just add -std=c11 to https://github.com/sio2project/sioworkers/blob/master/sio/compilers/gcc.py#L7 , create a simple test and push it through review.

        Issue Links

          Activity

          Marcin Mielniczuk made changes -
          Field Original Value New Value
          Assignee Marcin Mielniczuk [ marmistrz ]
          Hide
          Gerrit Gerrit added a comment -
          Change I63dc062f7fc8d749402b64fd77d200d3882c4335, patchset 1
          https://gerrit.sio2project.mimuw.edu.pl/2624

          SIO-1843 use c11 standard

          Change-Id: I63dc062f7fc8d749402b64fd77d200d3882c4335
          Show
          Gerrit Gerrit added a comment - Change I63dc062f7fc8d749402b64fd77d200d3882c4335, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/2624 SIO-1843 use c11 standard Change-Id: I63dc062f7fc8d749402b64fd77d200d3882c4335
          Hide
          Gerrit Gerrit added a comment -
          Change I39a91fa48e31460ebc685aff3960f9cb53fe604f, patchset 1
          https://gerrit.sio2project.mimuw.edu.pl/2627

          SIO-1843 Use gnu99 instead of c11.

          Change-Id: I39a91fa48e31460ebc685aff3960f9cb53fe604f
          Show
          Gerrit Gerrit added a comment - Change I39a91fa48e31460ebc685aff3960f9cb53fe604f, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/2627 SIO-1843 Use gnu99 instead of c11. Change-Id: I39a91fa48e31460ebc685aff3960f9cb53fe604f
          Hide
          Gerrit Gerrit added a comment -
          Change I63dc062f7fc8d749402b64fd77d200d3882c4335, patchset 2
          https://gerrit.sio2project.mimuw.edu.pl/2624

          SIO-1843 use the gnu99 standard

          Change-Id: I63dc062f7fc8d749402b64fd77d200d3882c4335
          Show
          Gerrit Gerrit added a comment - Change I63dc062f7fc8d749402b64fd77d200d3882c4335, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/2624 SIO-1843 use the gnu99 standard Change-Id: I63dc062f7fc8d749402b64fd77d200d3882c4335
          Marcin Mielniczuk made changes -
          Comment [ resolved by I63dc062f7fc8d749402b64fd77d200d3882c4335 ]
          Szymon Acedański made changes -
          Link This issue is blocked by SIO-1846 [ SIO-1846 ]
          Szymon Acedański made changes -
          Labels easy tag1
          Hide
          Maciej Matraszek added a comment -
          Regarding the recent commit: files in the sioworkers/tree/master/sio/compilers/test/sources directory are not magically compiled. Please add an entry here: https://github.com/sio2project/sioworkers/blob/master/sio/compilers/test/test_compilers.py#L118
          Show
          Maciej Matraszek added a comment - Regarding the recent commit: files in the sioworkers/tree/master/sio/compilers/test/sources directory are not magically compiled. Please add an entry here: https://github.com/sio2project/sioworkers/blob/master/sio/compilers/test/test_compilers.py#L118
          Marcin Mielniczuk made changes -
          Status New [ 10000 ] Open [ 1 ]
          Hide
          Marcin Mielniczuk added a comment - - edited
          Thanks, a patch set is awaiting in gerrit

          Show
          Marcin Mielniczuk added a comment - - edited Thanks, a patch set is awaiting in gerrit
          Marcin Mielniczuk made changes -
          Assignee Marcin Mielniczuk [ marmistrz ]
          Szymon Acedański made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Szymon Acedański [ accek ]
          Resolution Fixed [ 1 ]
          Szymon Acedański made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          New New Open Open
          3d 8h 12m 1 Marcin Mielniczuk 2016-10-7 9:49
          Open Open Resolved Resolved
          796d 8h 26m 1 Szymon Acedański 2018-12-12 17:15
          Resolved Resolved Closed Closed
          103d 23h 25m 1 Szymon Acedański 2019-03-26 16:41

            People

            • Assignee:
              Szymon Acedański
              Reporter:
              Maciej Matraszek
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: