The SIO2 project
  1. The SIO2 project
  2. SIO-1682

Worker RPC implementation doesn't remove call from pending after timeout

        Details

        • Type: Bug Bug
        • Status: Closed Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: Evaluation Engine / Workers
        • Labels:
          None

          Description

          sio.protocol.rpc.WorkerRpc._timeout will errback the Deferred, but the entry in self.pendingCalls is not deleted. If a reply actually comes later, callback() on line 71 will raise AlreadyCalledError, which will cause the connection to be dropped.

          This ironically makes SIO-1681 slightly better, so that one has to be fixed first.

            Issue Links

            is blocked by

            Bug - A problem which impairs or prevents the functions of the product. SIO-1681 sioworkersd doesn't handle timeouts or network errors properly

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

              Activity

              Transition Time In Source Status Execution Times Last Executer Last Execution Date
              New New Resolved Resolved
              		35d 11h 16m 1 Bartosz Stebel 2015-11-12 11:05
              Resolved Resolved Closed Closed
              		1230d 5h 34m 1 Szymon Acedański 2019-03-26 16:40

                People

                • Assignee:
                  Szymon Acedański
                  Reporter:
                  Bartosz Stebel
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: