The SIO2 project
  1. The SIO2 project
  2. SIO-1682

Worker RPC implementation doesn't remove call from pending after timeout

        Details

        • Type: Bug Bug
        • Status: Closed Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: Evaluation Engine / Workers
        • Labels:
          None

          Description

          sio.protocol.rpc.WorkerRpc._timeout will errback the Deferred, but the entry in self.pendingCalls is not deleted. If a reply actually comes later, callback() on line 71 will raise AlreadyCalledError, which will cause the connection to be dropped.

          This ironically makes SIO-1681 slightly better, so that one has to be fixed first.

            Issue Links

            is blocked by

            Bug - A problem which impairs or prevents the functions of the product. SIO-1681 sioworkersd doesn't handle timeouts or network errors properly

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

              Activity

              Connect your code to JIRA

              Link every code change to JIRA just by adding an issue keys in commit messages. Bridge the gap back to your source and know which changes fixed which JIRA issues.

              Git & Mercurial in the cloud

              Collaborate across unlimited private code repositories.
              ConnectFind out more

              Git behind the firewall

              Manage and collaborate on Git repositories behind a firewall.
              ConnectFind out more

              Browse and search code

              Browse, search, and track source code repositories.
              ConnectFind out more
              Find more source code tools on the Atlassian Marketplace

                People

                • Assignee:
                  Szymon Acedański
                  Reporter:
                  Bartosz Stebel
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: