The SIO2 project
  1. The SIO2 project
  2. SIO-1682

Worker RPC implementation doesn't remove call from pending after timeout

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Current Version
    • Fix Version/s: None
    • Labels:
      None

      Description

      sio.protocol.rpc.WorkerRpc._timeout will errback the Deferred, but the entry in self.pendingCalls is not deleted. If a reply actually comes later, callback() on line 71 will raise AlreadyCalledError, which will cause the connection to be dropped.

      This ironically makes SIO-1681 slightly better, so that one has to be fixed first.

        Issue Links

          Activity

          Bartosz Stebel made changes -
          Field Original Value New Value
          Link This issue is blocked by SIO-1681 [ SIO-1681 ]
          Bartosz Stebel made changes -
          Status New [ 10000 ] Resolved [ 5 ]
          Assignee Bartosz Stebel [ implr ] Szymon Acedański [ accek ]
          Resolution Fixed [ 1 ]
          Szymon Acedański made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Szymon Acedański
              Reporter:
              Bartosz Stebel
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: