The SIO2 project
  1. The SIO2 project
  2. SIO-1483

Unify submission status throughout the system

        Details

        • Type: Improvement Improvement
        • Status: Closed Closed
        • Priority: Minor Minor
        • Resolution: Won't Fix
        • Affects Version/s: Current Version
        • Fix Version/s: None
        • Component/s: OIOIOI
        • Labels:
          None

          Description

          We have many places around the system, where some submission status is defined:
          - https://github.com/sio2project/oioioi/blob/master/oioioi/contests/models.py#L229 ,
          - https://github.com/sio2project/oioioi/blob/master/oioioi/submitsqueue/models.py#L13 ,
          - SIO-1293 ,
          - ?????

          This leads to many problems, like: SIO-1482 . Therefore, I think it would be a good idea to have one common place for submissions statuses and to keep them all hardcoded there.

            Activity

            Ascending order - Click to sort in descending order
            Tomasz Zakrzewski made changes -
            Field Original Value New Value
            Link This issue relates to SIO-1482 [ SIO-1482 ]
            Filip Ochnik made changes -
            Description We have many places around the system, where some submission status is defined:
            - https://github.com/sio2project/oioioi/blob/master/oioioi/contests/models.py ,
            - https://github.com/sio2project/oioioi/blob/master/oioioi/submitsqueue/models.py ,
            - SIO-1293 ,
            - ?????

            This leads to many problem, like: SIO-1482 . Therefore, I think it would be a good idea to have one common place for submissions statuses and to keep them all hardcoded there.
            		We have many places around the system, where some submission status is defined:
            - https://github.com/sio2project/oioioi/blob/master/oioioi/contests/models.py#L229 ,
            - https://github.com/sio2project/oioioi/blob/master/oioioi/submitsqueue/models.py#L13 ,
            - SIO-1293 ,
            - ?????

            This leads to many problem, like: SIO-1482 . Therefore, I think it would be a good idea to have one common place for submissions statuses and to keep them all hardcoded there.
            Tomasz Zakrzewski made changes -
            Description We have many places around the system, where some submission status is defined:
            - https://github.com/sio2project/oioioi/blob/master/oioioi/contests/models.py#L229 ,
            - https://github.com/sio2project/oioioi/blob/master/oioioi/submitsqueue/models.py#L13 ,
            - SIO-1293 ,
            - ?????

            This leads to many problem, like: SIO-1482 . Therefore, I think it would be a good idea to have one common place for submissions statuses and to keep them all hardcoded there.
            		We have many places around the system, where some submission status is defined:
            - https://github.com/sio2project/oioioi/blob/master/oioioi/contests/models.py#L229 ,
            - https://github.com/sio2project/oioioi/blob/master/oioioi/submitsqueue/models.py#L13 ,
            - SIO-1293 ,
            - ?????

            This leads to many problems, like: SIO-1482 . Therefore, I think it would be a good idea to have one common place for submissions statuses and to keep them all hardcoded there.
            Hide
            Permalink
            Maciej Matraszek added a comment -
            Submitsqueue define *states* not *statuses*. That's something really different, just like SubmissionReport.status and ScoreReport.status share common name, but nothing more – the former is a process, and the latter a result. How would you unify it?
            Show
            Maciej Matraszek added a comment - Submitsqueue define *states* not *statuses*. That's something really different, just like SubmissionReport.status and ScoreReport.status share common name, but nothing more – the former is a process, and the latter a result. How would you unify it?
            Hide
            Permalink
            Michał Woś added a comment - - edited
            "This leads to many problems, like: SIO-1482 " - Tomasz, it has nothing common with your conclusion.
            I explained why below SIO-1482 report.

            Apart from above, this seems natural that statuses are registered in many modules. Statuses are dependent on the available functionalities which each module brings.
            Turn off one module should hide statuses which are connected only with that module.

            To my mind this report should be closed.
            Show
            Michał Woś added a comment - - edited "This leads to many problems, like: SIO-1482 " - Tomasz, it has nothing common with your conclusion. I explained why below SIO-1482 report. Apart from above, this seems natural that statuses are registered in many modules. Statuses are dependent on the available functionalities which each module brings. Turn off one module should hide statuses which are connected only with that module. To my mind this report should be closed.
            Michał Woś made changes -
            Link This issue relates to SIO-1482 [ SIO-1482 ]
            Tomasz Zakrzewski made changes -
            Status New [ 10000 ] Resolved [ 5 ]
            Assignee Szymon Acedański [ accek ]
            Resolution Won't Fix [ 2 ]
            Szymon Acedański made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            Transition Time In Source Status Execution Times Last Executer Last Execution Date
            New New Resolved Resolved
            		27d 21h 57m 1 Tomasz Zakrzewski 2014-04-24 9:46
            Resolved Resolved Closed Closed
            		158d 11h 54m 1 Szymon Acedański 2014-09-29 21:41

              People

              • Assignee:
                Szymon Acedański
                Reporter:
                Tomasz Zakrzewski
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: