Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Won't Fix
-
Affects Version/s: Current Version
-
Fix Version/s: Current Version
-
Component/s: OIOIOI
-
Labels:None
Description
When a submission is deleted before it's processed in evalmgr:
Traceback (most recent call last):
File "/vol/sio2/oioioi/oioioi/evalmgr/__init__.py", line 149, in evalmgr_job
File "/vol/sio2/oioioi/oioioi/evalmgr/__init__.py", line 77, in _run_phase
kwargs = phase[2].copy()
File "/vol/sio2/oioioi/oioioi/submitsqueue/handlers.py", line 9, in mark_submission_in_progress
submission = Submission.objects.get(id=env['submission_id'])
File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/db/models/manager.py", line 143, in get
return self.get_query_set().get(*args, **kwargs)
File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 404, in get
self.model._meta.object_name)
DoesNotExist: Submission matching query does not exist.
This ticket should also include writing a test for this case.
Traceback (most recent call last):
File "/vol/sio2/oioioi/oioioi/evalmgr/__init__.py", line 149, in evalmgr_job
File "/vol/sio2/oioioi/oioioi/evalmgr/__init__.py", line 77, in _run_phase
kwargs = phase[2].copy()
File "/vol/sio2/oioioi/oioioi/submitsqueue/handlers.py", line 9, in mark_submission_in_progress
submission = Submission.objects.get(id=env['submission_id'])
File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/db/models/manager.py", line 143, in get
return self.get_query_set().get(*args, **kwargs)
File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 404, in get
self.model._meta.object_name)
DoesNotExist: Submission matching query does not exist.
This ticket should also include writing a test for this case.
Activity
- All
- Comments
- History
- Activity
- Transitions
- Commits
I don't think this behavior was wrong. Our handlers raised these errors for ages and we have a special code to not spam admins in these cases. See also SIO-1254.
Show
Szymon Acedański
added a comment - I don't think this behavior was wrong. Our handlers raised these errors for ages and we have a special code to not spam admins in these cases. See also SIO-1254 .
Szymon Acedański
added a comment - I don't think this behavior was wrong. Our handlers raised these errors for ages and we have a special code to not spam admins in these cases. See also SIO-1254 . This one actually *was* wrong - I forgot to check for one exception. See the fix proposed in gerrit.
Basically this happens when somebody removes the Submission via Submissions view. It deletes the Submission model object as well as QueuedSubmit (this is ok), but the submit can still be in celery queue and therefore, the buggy handler will throw an exception.
Basically this happens when somebody removes the Submission via Submissions view. It deletes the Submission model object as well as QueuedSubmit (this is ok), but the submit can still be in celery queue and therefore, the buggy handler will throw an exception.
Show
Tomasz Zakrzewski
added a comment - - edited This one actually *was* wrong - I forgot to check for one exception. See the fix proposed in gerrit.
Basically this happens when somebody removes the Submission via Submissions view. It deletes the Submission model object as well as QueuedSubmit (this is ok), but the submit can still be in celery queue and therefore, the buggy handler will throw an exception.
Tomasz Zakrzewski
added a comment - - edited This one actually *was* wrong - I forgot to check for one exception. See the fix proposed in gerrit.
Basically this happens when somebody removes the Submission via Submissions view. It deletes the Submission model object as well as QueuedSubmit (this is ok), but the submit can still be in celery queue and therefore, the buggy handler will throw an exception. According to Szymon Acedański's comment, the current behavior is the desired one.
Show
Tomasz Zakrzewski
added a comment - According to Szymon Acedański's comment, the current behavior is the desired one.
Tomasz Zakrzewski
added a comment - According to Szymon Acedański's comment, the current behavior is the desired one. 
https://gerrit.sio2project.mimuw.edu.pl/1935
SIO-1412SubmitsQueue doesn't handle well disappearing submissions.Change-Id: Ic47744e2efb9f58fdadb30dded0f570a3836f053