[SIO-1323] Logo handling improvements - SIO2

Details

Type: Task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: Current Version
Fix Version/s: Near Future
Component/s: OIOIOI
Labels:
None

Sprint:
The Second Sprint

Description

The current contestlogo module is quite limited:

1. We can provide a URL to a logo image, but if we run over HTTPS and we don't have the logo on an external HTTPS-protected website, we get unacceptable warnings.

2. Some contest types could automatically have logos determined by them. I think the controller should be able to provide a default logo, in which case we should consider two scenarios
a) admins should be able to change or hide the logo (and menu graphics; see below)
b) admins should have no control over the logo if the contest controller provided one

3. The contestlogo module should also become responsible for the graphical elements in the contestant's menu. It's ridiculous that now we force to use the OI graphics with no way of changing it.

Activity

Ascending order - Click to sort in descending order

Szymon Acedański made changes - 2013-10-29 14:22

Field	Original Value	New Value
Fix Version/s		Near Future [ 11001 ]

Szymon Acedański made changes - 2013-10-29 17:42

Assignee

Bartosz Tarnawski [ donvel ]

Szymon Acedański made changes - 2013-10-29 17:45

Rank

Ranked higher

Szymon Acedański made changes - 2013-10-29 17:54

Sprint

The Second Sprint [ 3 ]

Szymon Acedański made changes - 2013-10-29 17:54

Rank

Ranked lower

Szymon Acedański made changes - 2013-10-30 10:37

Status

New [ 10000 ]

Open [ 1 ]

Hide

Permalink

Gerrit Gerrit added a comment - 2013-11-11 22:15

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 1
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2013-11-11 22:15 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2013-11-11 23:52

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2013-11-11 23:52 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2013-11-11 23:56

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2013-11-11 23:56 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2013-11-12 0:03

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2013-11-12 0:03 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2013-12-16 15:43

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 5
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2013-12-16 15:43 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 5 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2013-12-16 18:01

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 6
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2013-12-16 18:01 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 6 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-13 0:18

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 7
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-13 0:18 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 7 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-13 0:22

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 8
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-13 0:22 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 8 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-13 19:32

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 9
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-13 19:32 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 9 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-14 0:22

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 10
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-14 0:22 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 10 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-14 16:57

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 11
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-14 16:57 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 11 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-18 23:36

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 12
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-18 23:36 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 12 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-18 23:48

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 13
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-18 23:48 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 13 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-19 0:26

Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 14
https://gerrit.sio2project.mimuw.edu.pl/1863

~~SIO-1323~~ Logo handling improvements

Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Show

Gerrit Gerrit added a comment - 2014-01-19 0:26 Change I7036142318905b299767de399f3e77e33d4b50a8, patchset 14 https://gerrit.sio2project.mimuw.edu.pl/1863 SIO-1323 Logo handling improvements Change-Id: I7036142318905b299767de399f3e77e33d4b50a8

Hide

Permalink

Gerrit Gerrit added a comment - 2014-01-25 10:06

Change Ic5c6902612509c8111cd1da3f20bbb5a59241245, patchset 1
https://gerrit.sio2project.mimuw.edu.pl/1911

~~SIO-1323~~ Logo handling improvements

Change-Id: Ic5c6902612509c8111cd1da3f20bbb5a59241245

Show

Gerrit Gerrit added a comment - 2014-01-25 10:06 Change Ic5c6902612509c8111cd1da3f20bbb5a59241245, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/1911 SIO-1323 Logo handling improvements Change-Id: Ic5c6902612509c8111cd1da3f20bbb5a59241245

Bartosz Tarnawski made changes - 2014-01-30 22:53

Status	Open [ 1 ]	Resolved [ 5 ]
Assignee	Bartosz Tarnawski [ donvel ]	Szymon Acedański [ accek ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Maciej Dębski added a comment - 2014-02-3 19:27

Internal server errors after update.
This is due to migration, which creates ContestLogo objects with empty 'image' field. Or due to views which does not check for empty :P

Traceback (most recent call last):

  File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 115, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/views/decorators/cache.py", line 75, in _cache_controlled
    response = viewfunc(request, *args, **kw)

  File "/vol/sio2/oioioi/oioioi/contestlogo/views.py", line 21, in logo_image_view
    return stream_if_changed(request, logo)

  File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/views/decorators/http.py", line 147, in inner
    response = func(request, *args, **kwargs)

  File "/vol/sio2/oioioi/oioioi/contestlogo/views.py", line 15, in stream_if_changed
    return stream_file(image_object.image)

  File "/vol/sio2/oioioi/oioioi/filetracker/utils.py", line 77, in stream_file
    name = unicode(django_file.name.rsplit('/', 1)[-1])

AttributeError: 'NoneType' object has no attribute 'rsplit'

Show

Maciej Dębski added a comment - 2014-02-3 19:27 Internal server errors after update. This is due to migration, which creates ContestLogo objects with empty 'image' field. Or due to views which does not check for empty :P Traceback (most recent call last): File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 115, in get_response response = callback(request, *callback_args, **callback_kwargs) File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/views/decorators/cache.py", line 75, in _cache_controlled response = viewfunc(request, *args, **kw) File "/vol/sio2/oioioi/oioioi/contestlogo/views.py", line 21, in logo_image_view return stream_if_changed(request, logo) File "/vol/sio2/venv/local/lib/python2.7/site-packages/django/views/decorators/http.py", line 147, in inner response = func(request, *args, **kwargs) File "/vol/sio2/oioioi/oioioi/contestlogo/views.py", line 15, in stream_if_changed return stream_file(image_object.image) File "/vol/sio2/oioioi/oioioi/filetracker/utils.py", line 77, in stream_file name = unicode(django_file.name.rsplit('/', 1)[-1]) AttributeError: 'NoneType' object has no attribute 'rsplit'

Maciej Dębski made changes - 2014-02-3 19:27

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]
Assignee	Szymon Acedański [ accek ]	Bartosz Tarnawski [ donvel ]

Hide

Permalink

Gerrit Gerrit added a comment - 2014-02-18 16:46

Change I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0, patchset 1
https://gerrit.sio2project.mimuw.edu.pl/1965

~~SIO-1323~~ Logo handling improvements

Change-Id: I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0

Show

Gerrit Gerrit added a comment - 2014-02-18 16:46 Change I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/1965 SIO-1323 Logo handling improvements Change-Id: I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0

Hide

Permalink

Gerrit Gerrit added a comment - 2014-02-18 18:46

Change I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0, patchset 2
https://gerrit.sio2project.mimuw.edu.pl/1965

~~SIO-1323~~ Logo handling improvements

Change-Id: I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0

Show

Gerrit Gerrit added a comment - 2014-02-18 18:46 Change I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/1965 SIO-1323 Logo handling improvements Change-Id: I0a727ce2e0aa971e51ee6284e4c688df7cef7ff0

Bartosz Tarnawski made changes - 2014-02-24 12:47

Status	Reopened [ 4 ]	Resolved [ 5 ]
Assignee	Bartosz Tarnawski [ donvel ]	Szymon Acedański [ accek ]
Resolution		Fixed [ 1 ]

Szymon Acedański made changes - 2014-09-29 21:41

Status

Resolved [ 5 ]

Closed [ 6 ]

Transition

Time In Source Status

Execution Times

Last Executer

Last Execution Date

New

Open

3d 22h 49m

Szymon Acedański

2013-10-30 10:37

Open

Resolved

92d 12h 16m

Bartosz Tarnawski

2014-01-30 22:53

Resolved

Reopened

3d 20h 33m

Maciej Dębski

2014-02-3 19:27

Reopened

Resolved

20d 17h 20m

Bartosz Tarnawski

2014-02-24 12:47

Resolved

Closed

217d 7h 53m

Szymon Acedański

2014-09-29 21:41

People

Assignee:

Szymon Acedański

Reporter:

Szymon Acedański

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

2013-10-26 12:48

Updated:

2014-09-29 21:41

Resolved:

2014-02-24 12:47

Agile

Completed Sprint:

The Second Sprint ended 2014-09-29
View on Board