[SIO-1284] filetracker-server support for logging to stderr - SIO2

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: Current Version
Fix Version/s: None
Component/s: Evaluation Engine / Workers
Labels:
None

Sprint:
The First Sprint, The Second Sprint

Description

This is needed to use the supervisord's log rotation facility out of the box. For now filetracker logs are not rotated and it's not good...

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Marek Bardoński added a comment - 2013-10-22 1:56

filetracker-server is emmiting two kinds of logs, one from standard logger which is going to stdout, another from lighthttpd (using mod_accesslog) is going where the log file is specified, now to the log file

According to documentation, we can choose the stderr [1] instead of our custom log file by passing the argument

accesslog <log:string> Defines the log target ("stderr", filename, etc)

Then the stream will be redirected to stderr, catched by supervisord to rotated log.

[1] http://redmine.lighttpd.net/projects/4/wiki/Mod_accesslog

What was done in my change

Show

Marek Bardoński added a comment - 2013-10-22 1:56 filetracker-server is emmiting two kinds of logs, one from standard logger which is going to stdout, another from lighthttpd (using mod_accesslog) is going where the log file is specified, now to the log file According to documentation, we can choose the stderr [1] instead of our custom log file by passing the argument accesslog <log:string> Defines the log target ("stderr", filename, etc) Then the stream will be redirected to stderr, catched by supervisord to rotated log. [1] http://redmine.lighttpd.net/projects/4/wiki/Mod_accesslog What was done in my change

13 older comments

Hide

Permalink

Marek Bardoński added a comment - 2013-11-4 13:35

I've prepared a pull request to visualize my idea.

Anyway, still when I'll enter http://students.mimuw.edu.pl:9999/cokolwiek, then filetracker server respond with error 400, but no information about this is generated in logs. Please confirm, that this is a bad sign, and I'll investigate more.

Show

Marek Bardoński added a comment - 2013-11-4 13:35 I've prepared a pull request to visualize my idea. Anyway, still when I'll enter http://students.mimuw.edu.pl:9999/cokolwiek, then filetracker server respond with error 400, but no information about this is generated in logs. Please confirm, that this is a bad sign, and I'll investigate more.

Hide

Permalink

Szymon Acedański added a comment - 2013-11-4 14:07

Yes, that's a bad sign. Before this change such a request was logged (albeit not to stderr, but to file named 'stderr').

Have a look at what was logged before your first change, and the intended behavior is to log the same thing, just through stderr, so that supervisord will handle it. I think it's clear. Please do not send changes for review until you actually verified that this works.

Show

Szymon Acedański added a comment - 2013-11-4 14:07 Yes, that's a bad sign. Before this change such a request was logged (albeit not to stderr, but to file named 'stderr'). Have a look at what was logged before your first change, and the intended behavior is to log the same thing, just through stderr, so that supervisord will handle it. I think it's clear. Please do not send changes for review until you actually verified that this works.

Hide

Permalink

Gerrit Gerrit added a comment - 2013-11-5 12:21

Change I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7, patchset 3
https://gerrit.sio2project.mimuw.edu.pl/1839

~~SIO-1284~~ filetracker-server support for logging to stderr (fix to last commit)

Change-Id: I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7

Show

Gerrit Gerrit added a comment - 2013-11-5 12:21 Change I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/1839 SIO-1284 filetracker-server support for logging to stderr (fix to last commit) Change-Id: I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7

Hide

Permalink

Marek Bardoński added a comment - 2013-11-5 12:26

Okey, now it's verified. I got this kind of messages processed via stderr to /logs/filetracker-supervisord.log

Example message "77.115.72.123 students.mimuw.edu.pl:9999 - [05/Nov/2013:12:14:56 +0100] "GET /cokolwiekk HTTP/1.1" 404 345 "-" "Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.123.1599.101 Safari/537.36"
"

No change to filetracker itself is need.

Show

Marek Bardoński added a comment - 2013-11-5 12:26 Okey, now it's verified. I got this kind of messages processed via stderr to /logs/filetracker-supervisord.log Example message "77.115.72.123 students.mimuw.edu.pl:9999 - [05/Nov/2013:12:14:56 +0100] "GET /cokolwiekk HTTP/1.1" 404 345 "-" "Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.123.1599.101 Safari/537.36" " No change to filetracker itself is need.

Hide

Permalink

Gerrit Gerrit added a comment - 2013-11-5 15:01

Change I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7, patchset 4
https://gerrit.sio2project.mimuw.edu.pl/1839

~~SIO-1284~~ filetracker-server support for logging to stderr (fix to last commit)

Change-Id: I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7

Show

Gerrit Gerrit added a comment - 2013-11-5 15:01 Change I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/1839 SIO-1284 filetracker-server support for logging to stderr (fix to last commit) Change-Id: I146f47ff1e347a8c92bf1ff530e2bac1a4f3e5f7

People

Assignee:

Szymon Acedański

Reporter:

Szymon Acedański

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

2013-08-7 11:54

Updated:

2014-10-29 13:30

Resolved:

2013-11-7 16:32

Agile

Completed Sprints:

The First Sprint ended 2013-10-29
The Second Sprint ended 2014-09-29
View on Board