The SIO2 project
  1. The SIO2 project
  2. SIO-1223

Functions checking conditions shouldn't throw exceptions if request.contest is null.

        Details

        • Type: Bug Bug
        • Status: Closed Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 0.1.7
        • Fix Version/s: 0.1.9
        • Component/s: OIOIOI
        • Labels:
          None

          Description

          Or something like that. Anyway, in base/menu.py there is strange 'catch Exception:' which catches exceptions thrown by that functions.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 1
            https://gerrit.sio2project.mimuw.edu.pl/1616

            SIO-1223 Menu items' conditions fix

            Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Show
            Gerrit Gerrit added a comment - Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/1616 SIO-1223 Menu items' conditions fix Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 2
            https://gerrit.sio2project.mimuw.edu.pl/1616

            SIO-1223 Menu items' conditions fix

            Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Show
            Gerrit Gerrit added a comment - Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/1616 SIO-1223 Menu items' conditions fix Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 3
            https://gerrit.sio2project.mimuw.edu.pl/1616

            SIO-1223 Menu items' conditions fix

            Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Show
            Gerrit Gerrit added a comment - Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/1616 SIO-1223 Menu items' conditions fix Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 4
            https://gerrit.sio2project.mimuw.edu.pl/1616

            SIO-1223 Menu items' conditions fix

            Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Show
            Gerrit Gerrit added a comment - Change Iaed8219fd970a6935b46324fd7139818f1a6a439, patchset 4 https://gerrit.sio2project.mimuw.edu.pl/1616 SIO-1223 Menu items' conditions fix Change-Id: Iaed8219fd970a6935b46324fd7139818f1a6a439
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 6
            https://gerrit.sio2project.mimuw.edu.pl/1673

            SIO-1223 New conditions for menu items and views

            Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Show
            Gerrit Gerrit added a comment - Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 6 https://gerrit.sio2project.mimuw.edu.pl/1673 SIO-1223 New conditions for menu items and views Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 7
            https://gerrit.sio2project.mimuw.edu.pl/1673

            SIO-1223 New conditions for menu items and views

            Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Show
            Gerrit Gerrit added a comment - Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 7 https://gerrit.sio2project.mimuw.edu.pl/1673 SIO-1223 New conditions for menu items and views Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 8
            https://gerrit.sio2project.mimuw.edu.pl/1673

            SIO-1223 New conditions for menu items and views

            Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Show
            Gerrit Gerrit added a comment - Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 8 https://gerrit.sio2project.mimuw.edu.pl/1673 SIO-1223 New conditions for menu items and views Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 9
            https://gerrit.sio2project.mimuw.edu.pl/1673

            SIO-1223 New conditions for menu items and views

            Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Show
            Gerrit Gerrit added a comment - Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 9 https://gerrit.sio2project.mimuw.edu.pl/1673 SIO-1223 New conditions for menu items and views Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 10
            https://gerrit.sio2project.mimuw.edu.pl/1673

            SIO-1223 New conditions for menu items and views

            Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844
            Show
            Gerrit Gerrit added a comment - Change I35052c10e043a4f68f8c76ca1e3e2a318b64d844, patchset 10 https://gerrit.sio2project.mimuw.edu.pl/1673 SIO-1223 New conditions for menu items and views Change-Id: I35052c10e043a4f68f8c76ca1e3e2a318b64d844

              People

              • Assignee:
                Szymon Acedański
                Reporter:
                Maciej Matraszek
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: