The SIO2 project
  1. The SIO2 project
  2. SIO-1177

Ambiguous method of group score calculation

        Details

        • Type: Bug Bug
        • Status: Closed Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 0.1.5
        • Fix Version/s: None
        • Component/s: OIOIOI
        • Labels:
          None
        • Sprint:
          The First Sprint

          Description

          Currently there's assumption that all tests in one group have the same max score, but there's no code verifying it.
          Calculating group max score is just taking max score from group's first test.
          Probably the best method how to deal with it is checking if tests in groups share the same max score while uploading SINOL package.

            Issue Links

            is related to

            Improvement - An improvement or enhancement to an existing feature or task. SIO-1319 Add max_score fields to models

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Maciej Matraszek added a comment -
              AFAIK group scorers (programs/utils.py) don't assume anything about distribution of maximal score. For example in sum_group_scorer it's perfectly ok, to have diffrent max_score for each test.
              The only place I found which assumes that is in generating submission report. What I propose is adding max_score field to GroupReport (as some information is already doubled in in TestReport).
              Show
              Maciej Matraszek added a comment - AFAIK group scorers (programs/utils.py) don't assume anything about distribution of maximal score. For example in sum_group_scorer it's perfectly ok, to have diffrent max_score for each test. The only place I found which assumes that is in generating submission report. What I propose is adding max_score field to GroupReport (as some information is already doubled in in TestReport).
              Mateusz Kwapich made changes -
              Field Original Value New Value
              Fix Version/s 0.1.6 [ 11300 ]
              Mateusz Kwapich made changes -
              Assignee Patryk Hes [ pathes ]
              Mateusz Kwapich made changes -
              Status New [ 10000 ] Open [ 1 ]
              Mateusz Kwapich made changes -
              Assignee Patryk Hes [ pathes ]
              Mateusz Kwapich made changes -
              Fix Version/s 0.1.6 [ 11300 ]
              Szymon Acedański made changes -
              Fix Version/s The First Sprint [ 11500 ]
              Szymon Acedański made changes -
              Assignee Bartosz Tarnawski [ donvel ]
              Szymon Acedański made changes -
              Sprint The First Sprint [ 2 ]
              Hide
              Permalink
              Bartosz Tarnawski added a comment -
              SINOL packages don't define max scores for tests.
              Max scores are set automatically during uploading and may be later changed by contest admins.
              Show
              Bartosz Tarnawski added a comment - SINOL packages don't define max scores for tests. Max scores are set automatically during uploading and may be later changed by contest admins.
              Hide
              Permalink
              Bartosz Tarnawski added a comment -
              A sub-task of this issue can be https://jira.sio2project.mimuw.edu.pl/browse/SIO-1319
              Show
              Bartosz Tarnawski added a comment - A sub-task of this issue can be https://jira.sio2project.mimuw.edu.pl/browse/SIO-1319
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change I28e54e4c965a4f1d6d6206f8135a4b35befe6702, patchset 1
              https://gerrit.sio2project.mimuw.edu.pl/1815

              SIO-1177 Ambiguous method of group score calculation

              Change-Id: I28e54e4c965a4f1d6d6206f8135a4b35befe6702
              Show
              Gerrit Gerrit added a comment - Change I28e54e4c965a4f1d6d6206f8135a4b35befe6702, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/1815 SIO-1177 Ambiguous method of group score calculation Change-Id: I28e54e4c965a4f1d6d6206f8135a4b35befe6702
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change I28e54e4c965a4f1d6d6206f8135a4b35befe6702, patchset 2
              https://gerrit.sio2project.mimuw.edu.pl/1815

              SIO-1177 Ambiguous method of group score calculation

              Change-Id: I28e54e4c965a4f1d6d6206f8135a4b35befe6702
              Show
              Gerrit Gerrit added a comment - Change I28e54e4c965a4f1d6d6206f8135a4b35befe6702, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/1815 SIO-1177 Ambiguous method of group score calculation Change-Id: I28e54e4c965a4f1d6d6206f8135a4b35befe6702
              Hide
              Permalink
              Gerrit Gerrit added a comment -
              Change I28e54e4c965a4f1d6d6206f8135a4b35befe6702, patchset 3
              https://gerrit.sio2project.mimuw.edu.pl/1815

              SIO-1177 Ambiguous method of group score calculation

              Change-Id: I28e54e4c965a4f1d6d6206f8135a4b35befe6702
              Show
              Gerrit Gerrit added a comment - Change I28e54e4c965a4f1d6d6206f8135a4b35befe6702, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/1815 SIO-1177 Ambiguous method of group score calculation Change-Id: I28e54e4c965a4f1d6d6206f8135a4b35befe6702
              Bartosz Tarnawski made changes -
              Link This issue is related to SIO-1319 [ SIO-1319 ]
              Bartosz Tarnawski made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Assignee Bartosz Tarnawski [ donvel ] Szymon Acedanski [ accek ]
              Resolution Fixed [ 1 ]
              Szymon Acedański made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Szymon Acedański made changes -
              Fix Version/s The First Sprint [ 11500 ]
              Transition Time In Source Status Execution Times Last Executer Last Execution Date
              New New Open Open
              		37d 2h 6m 1 Mateusz Kwapich 2013-03-5 13:12
              Open Open Resolved Resolved
              		232d 8h 42m 1 Bartosz Tarnawski 2013-10-23 22:55
              Resolved Resolved Closed Closed
              		340d 22h 47m 1 Szymon Acedański 2014-09-29 21:42

                People

                • Assignee:
                  Szymon Acedański
                  Reporter:
                  Patryk Hes
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Agile