The SIO2 project
  1. The SIO2 project
  2. SIO-1124

convert naive datetime objects to timezone aware

        Details

        • Type: Bug Bug
        • Status: Resolved Resolved
        • Priority: Major Major
        • Resolution: Obsolete
        • Affects Version/s: 0.1.2
        • Fix Version/s: None
        • Component/s: OIOIOI
        • Labels:

          Description

          replace all datetime.datetime.now() with django.utils.timezone.now() ?

            Activity

            Ascending order - Click to sort in descending order
            Michał Adamczyk made changes -
            Field Original Value New Value
            Assignee Michał Adamczyk [ saddam ]
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Ib5b87048f79ffc4f98d1b24a5339712563069e34, patchset 1
            https://gerrit.sio2project.mimuw.edu.pl/1425

            SIO-1124 better support timezone-aware datetimes

            Change-Id: Ib5b87048f79ffc4f98d1b24a5339712563069e34
            Show
            Gerrit Gerrit added a comment - Change Ib5b87048f79ffc4f98d1b24a5339712563069e34, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/1425 SIO-1124 better support timezone-aware datetimes Change-Id: Ib5b87048f79ffc4f98d1b24a5339712563069e34
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Ib5b87048f79ffc4f98d1b24a5339712563069e34, patchset 2
            https://gerrit.sio2project.mimuw.edu.pl/1425

            SIO-1124 better support timezone-aware datetimes

            Change-Id: Ib5b87048f79ffc4f98d1b24a5339712563069e34
            Show
            Gerrit Gerrit added a comment - Change Ib5b87048f79ffc4f98d1b24a5339712563069e34, patchset 2 https://gerrit.sio2project.mimuw.edu.pl/1425 SIO-1124 better support timezone-aware datetimes Change-Id: Ib5b87048f79ffc4f98d1b24a5339712563069e34
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change Ib5b87048f79ffc4f98d1b24a5339712563069e34, patchset 3
            https://gerrit.sio2project.mimuw.edu.pl/1425

            SIO-1124 better support timezone-aware datetimes

            Change-Id: Ib5b87048f79ffc4f98d1b24a5339712563069e34
            Show
            Gerrit Gerrit added a comment - Change Ib5b87048f79ffc4f98d1b24a5339712563069e34, patchset 3 https://gerrit.sio2project.mimuw.edu.pl/1425 SIO-1124 better support timezone-aware datetimes Change-Id: Ib5b87048f79ffc4f98d1b24a5339712563069e34
            Michał Adamczyk made changes -
            Status New [ 10000 ] Open [ 1 ]
            Michał Adamczyk made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Assignee Michał Adamczyk [ saddam ] Szymon Acedański [ accek ]
            Resolution Fixed [ 1 ]
            Szymon Acedański made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            Hide
            Permalink
            Michał Sidor added a comment -
            as seen last night during the daylight saving switch https://sentry.io/share/issue/a7b4ee32b38c48c68279e97d05356902/

            there are still multiple occurences of datetime.now() in the code
            Show
            Michał Sidor added a comment - as seen last night during the daylight saving switch https://sentry.io/share/issue/a7b4ee32b38c48c68279e97d05356902/ there are still multiple occurences of datetime.now() in the code
            Michał Sidor made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Reopened [ 4 ]
            Hide
            Permalink
            Michał Sidor added a comment -
            or perhaps it would be more accurate to say that such occurences were introduced after this was closed (I am told mailnotifyd is a fairly fresh thing, 2016 or something)
            Show
            Michał Sidor added a comment - or perhaps it would be more accurate to say that such occurences were introduced after this was closed (I am told mailnotifyd is a fairly fresh thing, 2016 or something)
            Szymon Acedański made changes -
            Labels easy
            Szymon Acedański made changes -
            Assignee Szymon Acedański [ accek ]
            Hide
            Permalink
            Sentry added a comment - - edited
            https://sentry.io/the-sio2-project/oioioi/issues/745042696/?referrer=jira_plugin
            albo jak się nie ma konta:
            https://sentry.io/share/issue/a7b4ee32b38c48c68279e97d05356902/
            Show
            Sentry added a comment - - edited https://sentry.io/the-sio2-project/oioioi/issues/745042696/?referrer=jira_plugin albo jak się nie ma konta: https://sentry.io/share/issue/a7b4ee32b38c48c68279e97d05356902/
            Michał Sidor made changes -
            Assignee Michał Sidor [ michcioperz ]
            Hide
            Permalink
            Michał Sidor added a comment -
            Picking this up because apparently mailnotifyd isn't quite sending anything and Sentry hasn't been loud enough about it
            Show
            Michał Sidor added a comment - Picking this up because apparently mailnotifyd isn't quite sending anything and Sentry hasn't been loud enough about it
            Hide
            Permalink
            Sentry added a comment -
            https://sentry.io/the-sio2-project/szkopul/issues/807479365/?referrer=jira_plugin
            Show
            Sentry added a comment - https://sentry.io/the-sio2-project/szkopul/issues/807479365/?referrer=jira_plugin
            Hide
            Permalink
            Gerrit Gerrit added a comment -
            Change oioioi~master~Ic58aeb2cd3369b0b95170b2ef628c1580eaec8bb, patchset 1
            https://gerrit.sio2project.mimuw.edu.pl/3144

            (SIO-1124) Replace naive datetimes in mailnotifyd with timezone-aware ones

            Before this commit, the assertion in mailnotify fails every time due to
            comparison between naive and timezone-aware datetimes.

            Change-Id: Ic58aeb2cd3369b0b95170b2ef628c1580eaec8bb
            Show
            Gerrit Gerrit added a comment - Change oioioi~master~Ic58aeb2cd3369b0b95170b2ef628c1580eaec8bb, patchset 1 https://gerrit.sio2project.mimuw.edu.pl/3144 ( SIO-1124 ) Replace naive datetimes in mailnotifyd with timezone-aware ones Before this commit, the assertion in mailnotify fails every time due to comparison between naive and timezone-aware datetimes. Change-Id: Ic58aeb2cd3369b0b95170b2ef628c1580eaec8bb
            Hide
            Permalink
            Szymon Acedański added a comment -
            This issue has been automatically closed as Obsolete due to no activity for 365 days.

            Feel free to reopen it or create a new one if it's still relevant.
            Show
            Szymon Acedański added a comment - This issue has been automatically closed as Obsolete due to no activity for 365 days. Feel free to reopen it or create a new one if it's still relevant.
            Szymon Acedański made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Assignee Michał Sidor [ michcioperz ] Szymon Acedański [ accek ]
            Resolution Obsolete [ 7 ]
            Transition Time In Source Status Execution Times Last Executer Last Execution Date
            New New Open Open
            		2d 17h 1m 1 Michał Adamczyk 2012-10-24 12:53
            Open Open Resolved Resolved
            		6s 1 Michał Adamczyk 2012-10-24 12:53
            Resolved Resolved Closed Closed
            		705d 8h 49m 1 Szymon Acedański 2014-09-29 21:42
            Closed Closed Reopened Reopened
            		1489d 14h 54m 1 Michał Sidor 2018-10-28 11:37
            Reopened Reopened Resolved Resolved
            		547d 3h 51m 1 Szymon Acedański 2020-04-27 16:28

              People

              • Assignee:
                Szymon Acedański
                Reporter:
                Michał Adamczyk
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: